Skip to content

Conversation

@kurbansitterley
Copy link
Contributor

Fixes/Resolves:

#1502

Summary/Motivation:

Changes proposed in this PR:

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

Similarly, ``electricity`` is counted both as ``LCOW_aggregate_variable_opex['electricity']`` as well as part of the ``LCOW_aggregate_variable_opex['Pump']``. For this reason, the system LCOW
is the summation of all indexes in any of the component or aggregate expressions *except* those indexed by flow.

Specific Energy Consumption
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same breakdown for LCOW is applied to SEC and can be applied to other metrics by using the function that performs the breakdown (forgetting its name, but used for LCOW and SEC breakdowns)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_add_flow_component_breakdowns

Yes as I was writing this I was thinking maybe we could "unhide" this method and provide docs for it here so it is useful for other flows?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure- and I would double-check that we are testing the function with another dummy flow (or just another tracked quantity on a flowsheet)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bknueven wondering if you see any issues with unhiding _add_flow_component_breakdowns

@ksbeattie ksbeattie added the Priority:High High Priority Issue or PR label Dec 4, 2025
@kurbansitterley kurbansitterley marked this pull request as ready for review December 4, 2025 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority:High High Priority Issue or PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants