-
Notifications
You must be signed in to change notification settings - Fork 84
Document LCOW and SEC Breakdowns #1697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kurbansitterley
wants to merge
7
commits into
watertap-org:main
Choose a base branch
from
kurbansitterley:doc-lcow-sec-breakdown
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
620036c
initial intro section
kurbansitterley 55db766
document LCOW breakdowns
kurbansitterley 3d507f8
few corrections and improvements
kurbansitterley 720d70f
Merge branch 'main' into doc-lcow-sec-breakdown
kurbansitterley 12c8198
fix typo
kurbansitterley 9112f2e
add SEC and carbon intensity breakdown section
kurbansitterley 561336b
small mod
kurbansitterley File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same breakdown for LCOW is applied to SEC and can be applied to other metrics by using the function that performs the breakdown (forgetting its name, but used for LCOW and SEC breakdowns)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_add_flow_component_breakdownsYes as I was writing this I was thinking maybe we could "unhide" this method and provide docs for it here so it is useful for other flows?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure- and I would double-check that we are testing the function with another dummy flow (or just another tracked quantity on a flowsheet)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bknueven wondering if you see any issues with unhiding
_add_flow_component_breakdowns