Skip to content

Expand PR checks to include checking against academy repo #1714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
sufikaur wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Expand PR checks to include checking against academy repo #1714

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ef192d3
add watertap academy repo and run tests
Dec 16, 2025
8c9d682
change error message for pytest fail
Dec 18, 2025
54af2b7
uncomment out rest of lines
Dec 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions .github/workflows/checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,3 +275,24 @@ jobs:
- name: Run pytest with nbmake
run: |
pytest --nbmake --nbmake-kernel="${{ env.WATERTAP_KERNEL_NAME }}" **/*.ipynb
- name: Clone watertap-academy repository
uses: actions/checkout@v4
with:
repository: watertap-org/watertap_academy_fall_2025
path: watertap_academy_fall_2025

- name: Install academy kernel
run: |
jupyter kernelspec list
python -m ipykernel install --user --name "watertap-academy"
jupyter kernelspec list

- name: Run pytest on academy notebooks
run: |
cd watertap_academy_fall_2025
echo '::group::Running pytest on notebooks'
if ! pytest --nbmake --nbmake-kernel="watertap-academy" **/*.ipynb; then
echo "Pytest failed!"
exit 1
fi
echo '::endgroup::'
Loading