Fix USD detection for v24.08 compatibility #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buddly27
force-pushed
the
fix-backward-compatibility
branch
5 times, most recently
from
227e673 to
ee2fa80
Compare
buddly27
force-pushed
the
fix-backward-compatibility
branch
from
ee2fa80 to
b57dc59
Compare
davvid
approved these changes
May 14, 2025
Member
davvid
left a comment
davvid
left a comment
There was a problem hiding this comment.
Looks good. At some point the #define may not be available, so in the future we may need to vary this behavior purely based on the version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix CMake module to detect USD without requiring
usd::boostorusd::python, maintaining compatibility with OpenUSD v24.08.