chore: remove ignored dependencies from renovate config#7489
Conversation
There was a problem hiding this comment.
Pull request overview
Removes @rspack/core and @rsbuild/core from Renovate’s ignored dependency list so Renovate can resume proposing updates for them.
Changes:
- Dropped
@rspack/corefromignoreDepsin Renovate config. - Dropped
@rsbuild/corefromignoreDepsin Renovate config.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request enables automated updates for @rspack/core and @rsbuild/core by removing them from the ignoreDeps list in the Renovate configuration. Feedback suggests adding a grouping rule for Rsbuild-related dependencies to minimize pull request noise and maintain consistency with existing package groupings.
| // manually handle updates | ||
| 'node', | ||
| '@rspack/core', | ||
| '@rsbuild/core', |
There was a problem hiding this comment.
Un-ignoring @rsbuild/core without a corresponding grouping rule in packageRules will likely result in separate pull requests for each Rsbuild-related dependency update. To maintain consistency with the existing Rspack and Rslib groups and reduce PR noise, consider adding a package rule to group dependencies matching /rsbuild/ in the packageRules array.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ab1d2e20de
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ignoreDeps: [ | ||
| // manually handle updates | ||
| 'node', | ||
| '@rspack/core', | ||
| '@rsbuild/core', | ||
| // some loaders still depend on loader-utils v2 |
There was a problem hiding this comment.
Dropping @rsbuild/core from ignoreDeps allows Renovate to update the npm alias dependencies that intentionally pin v1 ("@rsbuild/core-v1": "npm:@rsbuild/core@^1.7.5" in files like packages/plugin-react/package.json:32 and other plugin package.json files). Because Renovate matching is by package name, those aliases become eligible for major bumps to v2, and tests that import @rsbuild/core-v1 (for example packages/plugin-react/tests/index.test.ts:2) would no longer validate v1 compatibility, which undermines the repository’s backward-compat coverage.
Useful? React with 👍 / 👎.
Summary
Removing
@rspack/coreand@rsbuild/corefrom the list of dependencies to be ignored by Renovate.