Skip to content

chore: remove ignored dependencies from renovate config #7489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chenjiahan merged 1 commit into from
Apr 14, 2026
+0 −2
Merged

chore: remove ignored dependencies from renovate config #7489

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/renovate.json5
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,6 @@
ignoreDeps: [
// manually handle updates
'node',
'@rspack/core',
'@rsbuild/core',
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Un-ignoring @rsbuild/core without a corresponding grouping rule in packageRules will likely result in separate pull requests for each Rsbuild-related dependency update. To maintain consistency with the existing Rspack and Rslib groups and reduce PR noise, consider adding a package rule to group dependencies matching /rsbuild/ in the packageRules array.

// some loaders still depend on loader-utils v2
Comment on lines 80 to 83
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Restore @rsbuild/core in ignoreDeps for v1 alias deps

Dropping @rsbuild/core from ignoreDeps allows Renovate to update the npm alias dependencies that intentionally pin v1 ("@rsbuild/core-v1": "npm:@rsbuild/core@^1.7.5" in files like packages/plugin-react/package.json:32 and other plugin package.json files). Because Renovate matching is by package name, those aliases become eligible for major bumps to v2, and tests that import @rsbuild/core-v1 (for example packages/plugin-react/tests/index.test.ts:2) would no longer validate v1 compatibility, which undermines the repository’s backward-compat coverage.

Useful? React with 👍 / 👎.

'loader-utils',
],
Expand Down
Loading