Skip to content

Move request-close command test into main dialog test file #50804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2025

Conversation

lukewarlow
Copy link
Member

No description provided.

Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to trust this. I'm assuming you have not actually modified the tests and browsers have the same results.

Copy link
Contributor

@keithamus keithamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 - but we should wait for whatwg/html#11045.

@lukewarlow lukewarlow force-pushed the untentative-request-close-command-tests branch from a7f93b0 to 6804d5a Compare May 22, 2025 14:16
annevk pushed a commit to whatwg/html that referenced this pull request May 23, 2025
This new command maps to the dialog's requestClose() method.

Tests: web-platform-tests/wpt#50804.
@annevk annevk merged commit 4b31e4c into master May 23, 2025
20 checks passed
@annevk annevk deleted the untentative-request-close-command-tests branch May 23, 2025 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants