Skip to content

Conversation

@chromium-wpt-export-bot
Copy link
Collaborator

This adds waiting for compositor ready to several tests. This ensures
that the tests are resilient to start up conditions

R=[email protected]

Change-Id: I4babaf579d172454586f1d633ab4ce5c4cb139ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6569910
Reviewed-by: Kevin Ellis <[email protected]>
Commit-Queue: Vladimir Levin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1463527}

This adds waiting for compositor ready to several tests. This ensures
that the tests are resilient to start up conditions

[email protected]

Change-Id: I4babaf579d172454586f1d633ab4ce5c4cb139ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6569910
Reviewed-by: Kevin Ellis <[email protected]>
Commit-Queue: Vladimir Levin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1463527}
Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

@jonathan-j-lee
Copy link
Contributor

WPT Command: python3 ./wpt run --channel=nightly --verify --verify-no-chaos-mode --verify-repeat-loop=0 --verify-repeat-restart=10 --github-checks-text-file=/home/test/artifacts/checkrun.md --affected base_head --log-mach-level=info --log-mach=- -y --no-pause --no-restart-on-unexpected --install-fonts --verify-log-full --no-headless --binary=/home/test/build/firefox/firefox firefox

Some affected tests had inconsistent (flaky) results:

Unstable results

Test Subtest Results Messages
/css/css-view-transitions/no-crash-set-exception.html ERROR: 2/10, OK: 8/10

These may be pre-existing or new flakes. Please try to reproduce (see the above WPT command, though some flags may not be needed when running locally) and determine if your change introduced the flake. If you are unable to reproduce the problem, please tag @web-platform-tests/wpt-core-team in a comment for help.

@jonathan-j-lee
Copy link
Contributor

@jcscottiii or @DanielRyanSmith: Filed https://crbug.com/419851393 for existing flakiness. Please force merge? Thanks!

@DanielRyanSmith DanielRyanSmith merged commit cb912e9 into master May 23, 2025
19 of 21 checks passed
@DanielRyanSmith DanielRyanSmith deleted the chromium-export-9db2772de4 branch May 23, 2025 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants