Skip to content

merge_pr_60225

Choose a tag to compare

@github-actions github-actions released this 28 May 07:26

Fix 3d transform check in HasDistortingVisualEffects

https://crrev.com/1629048 relies on HasDistortingVisualEffects
catching all cases where the target has a 3d transform. Unfortunately,
this was not the case because
GeometryMapper::SourceToDestinationProjection will flatten 3d
transforms, so the following check is insufficient:

  gfx::Transform projection = SourceToDestinationProjection(
      paint_properties.Transform(), root_properties.Transform());
  if (!projection.Is2dProportionalUpscaleAndOr2dTranslation())
    return true;

This patch fixes this issue by ensuring that the target and the root
are coplanar before relying on the projection.

Fixed: 517176673
Change-Id: Ia03596324a88252c054f0963f7aa08b60d1a5497
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7877217
Reviewed-by: Stefan Zager szager@chromium.org
Auto-Submit: Philip Rogers pdr@chromium.org
Commit-Queue: Philip Rogers pdr@chromium.org
Cr-Commit-Position: refs/heads/main@{#1637326}