This repository was archived by the owner on Jul 13, 2021. It is now read-only.
feat: add option to set client/server port seperatly for sockets #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
shellscape
changed the title
Contributor
|
Thanks for the PR 🍺 Really appreciate your efforts here. But it may have been premature before we've had the chance to discuss the proposal in #79. |
Author
|
That's entirely fine. This issue was blocking me locally so I wanted to test out the idea. I had some spare time so I figured I'd fork it and give it a shot. If there are changes you'd like to make to the proposal or the PR, or if you don't think the idea's worth adding we can go from there. |
Contributor
|
👍 Let's discuss on the issue you created. |
3 tasks
This was referenced Jul 2, 2018
michael-ciniawsky
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
Fixes #79.
Adds server/client configuration for the websocket port.
Breaking Changes
Additional Info