Add Scoped Custom Element Registries #1341

annevk · 2024-12-17T17:30:55Z

Please do not comment directly on this PR unless asked. It's a big change and we want to keep it manageable. Use #1339 instead.

HTML PR: whatwg/html#10869.

Tests: web-platform-tests/wpt#50790.

At least two implementers are interested (and none opposed):
- WebKit
- Gecko
- Chromium
Tests are written and can be reviewed and commented upon at:
Implementation bugs are filed:
- Chromium: https://issues.chromium.org/issues/399124619
- Gecko: https://bugzilla.mozilla.org/show_bug.cgi?id=1874414
- WebKit: N/A
MDN issue is filed: Scoped Custom Element Registries mdn/content#38266
The top of this comment includes a clear commit message to use.

(See WHATWG Working Mode: Changes for more details.)

Preview | Diff

Do not comment directly on this PR while it is in draft state. Use #10854 instead. DOM PR: whatwg/dom#1341. Tests: ...

DOM PR: whatwg/dom#1341. Tests: ... Closes #10854.

Part of whatwg/dom#1341.

For whatwg/dom#1341.

…nly (and invert its value), a=testonly Automatic update from web-platform-tests DOM: rename importNode()'s deep to selfOnly (and invert its value) Part of whatwg/dom#1341. -- wpt-commits: 5bcf44cb07a74e284893af96926d932ec09705e7 wpt-pr: 50860

…ith scoped registries, a=testonly Automatic update from web-platform-tests DOM: createElement and createElementNS with scoped registries For whatwg/dom#1341. -- wpt-commits: a52f97983743aae5fdd5172c9938b47743dc7146 wpt-pr: 50925

…nly (and invert its value), a=testonly Automatic update from web-platform-tests DOM: rename importNode()'s deep to selfOnly (and invert its value) Part of whatwg/dom#1341. -- wpt-commits: 5bcf44cb07a74e284893af96926d932ec09705e7 wpt-pr: 50860

…ith scoped registries, a=testonly Automatic update from web-platform-tests DOM: createElement and createElementNS with scoped registries For whatwg/dom#1341. -- wpt-commits: a52f97983743aae5fdd5172c9938b47743dc7146 wpt-pr: 50925

…nly (and invert its value), a=testonly Automatic update from web-platform-tests DOM: rename importNode()'s deep to selfOnly (and invert its value) Part of whatwg/dom#1341. -- wpt-commits: 5bcf44cb07a74e284893af96926d932ec09705e7 wpt-pr: 50860 UltraBlame original commit: 4a4c1689ebd912108057f71fa24393009d4ab18a

…ith scoped registries, a=testonly Automatic update from web-platform-tests DOM: createElement and createElementNS with scoped registries For whatwg/dom#1341. -- wpt-commits: a52f97983743aae5fdd5172c9938b47743dc7146 wpt-pr: 50925 UltraBlame original commit: 78ef3074b0082c9e95d840a8010b34661973a847

…nly (and invert its value), a=testonly Automatic update from web-platform-tests DOM: rename importNode()'s deep to selfOnly (and invert its value) Part of whatwg/dom#1341. -- wpt-commits: 5bcf44cb07a74e284893af96926d932ec09705e7 wpt-pr: 50860 UltraBlame original commit: 4a4c1689ebd912108057f71fa24393009d4ab18a

…ith scoped registries, a=testonly Automatic update from web-platform-tests DOM: createElement and createElementNS with scoped registries For whatwg/dom#1341. -- wpt-commits: a52f97983743aae5fdd5172c9938b47743dc7146 wpt-pr: 50925 UltraBlame original commit: 78ef3074b0082c9e95d840a8010b34661973a847

foolip

Editorial review done.

foolip · 2025-03-20T22:09:03Z

dom.bs

@@ -6499,6 +6678,26 @@ null), and boolean <var>synchronousCustomElements</var> (default false):
 <li><p>Return <var>result</var>.
 </ol>

+<p>To <dfn>create an element internal</dfn> given a <a for=/>document</a> <var>document</var>, an


I actually am not sure what effect the noexport attribute has, but it's used elsewhere in DOM for spec-internal stuff, so:

Suggested change

<p>To <dfn>create an element internal</dfn> given a <a for=/>document</a> <var>document</var>, an

<p>To <dfn noexport>create an element internal</dfn> given a <a for=/>document</a> <var>document</var>, an

Also, I first thought this might be related to ElementInternals, so a name like "internal create element steps" or "inner create element steps" would help avoid that. Not a big deal though.

I mostly stopped using that as it doesn't have an effect. Except maybe to emphasize but I don't think that's needed here.

foolip · 2025-03-20T22:13:26Z

dom.bs

-
-     <li><p>Assert: <var>result</var>'s <a for=Element>custom element state</a> and
-     <a for=Element>custom element definition</a> are initialized.
+     <li><p><a for=map>Set</a> the <a>surrounding agent</a>'s


It's very hard to follow the diff here inside "create an element", so for any other reviews, I think the main things are:

Refactoring to use a "creating an element internal" helper, which takes the registry as an argument.

A bunch of steps nested one more level under "Run these steps while catching any exceptions", ending with the added "Set result’s custom element registry to registry."

Basically searching for "registry" within the steps shows the interesting stuff.

And I can't find anything wrong :)

dom.bs

…nly (and invert its value), a=testonly Automatic update from web-platform-tests DOM: rename importNode()'s deep to selfOnly (and invert its value) Part of whatwg/dom#1341. -- wpt-commits: 5bcf44cb07a74e284893af96926d932ec09705e7 wpt-pr: 50860

…ith scoped registries, a=testonly Automatic update from web-platform-tests DOM: createElement and createElementNS with scoped registries For whatwg/dom#1341. -- wpt-commits: a52f97983743aae5fdd5172c9938b47743dc7146 wpt-pr: 50925

HTML PR: whatwg/html#10869. Tests: ... Closes #1339.

DOM PR: whatwg/dom#1341. Tests: ... Closes #10854.

…gistry into registries And rename away from .tentative for the Revamped Scoped Custom Element Registry tests as whatwg/html#10869 and whatwg/dom#1341 are about to land.

DOM PR: whatwg/dom#1341. Tests: web-platform-tests/wpt#50790 & and others & web-platform-tests/wpt#51953. Closes #10854.

keithamus · 2025-04-14T15:35:41Z

dom.bs

+ <li><p>Let <var>is</var> be null.
+
+ <li>
+  <p>If <var>options</var> is a dictionary:


I think we're missing the alternate case here, for when options is a string - is is never set to options AFAICT.

That is correct? It never was either.

This implements the IDL definitions per the spec issue[1], however all methods are basic stubs and do not execute any logic - the logic will come with later patches. I2P: https://groups.google.com/a/chromium.org/g/blink-dev/c/um-9YjJWyEQ/m/MhKN0L7FAgAJ Spec PRs: HTML: whatwg/html#10869 DOM: whatwg/dom#1341 [1]: whatwg/html#10854 Bug: 409577162 Change-Id: Ieee709ff15c13bdd0b1d7598e27031867062b592 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6443776 Reviewed-by: David Baron <[email protected]> Commit-Queue: Keith Cirkel <[email protected]> Commit-Queue: David Baron <[email protected]> Auto-Submit: Keith Cirkel <[email protected]> Cr-Commit-Position: refs/heads/main@{#1446589}

This corresponds to a couple of spec changes: whatwg/html#10869 whatwg/dom#1341 The regressions are unfortunate and need looking into. The spec issues I've reported mostly have fixes PRed too. Just going to wait for those.

This corresponds primarily to these spec changes, plus a few follow-up spec fixes: whatwg/dom#1341 whatwg/html#10869 Still looking into the test regressions. Those might be spec issues but I'm currently assuming they're me issues. :^)

…egistry and custom-element-registry into registries, a=testonly Automatic update from web-platform-tests custom-elements: merge revamped-scoped-registry and custom-element-registry into registries And rename away from .tentative for the Revamped Scoped Custom Element Registry tests as whatwg/html#10869 and whatwg/dom#1341 are about to land. -- wpt-commits: 7087b359a1e2e306db934e5ff11218bd871cb228 wpt-pr: 51953

…ed registry, a=testonly Automatic update from web-platform-tests Scaffold out basic IDL for revamped scoped registry This implements the IDL definitions per the spec issue[1], however all methods are basic stubs and do not execute any logic - the logic will come with later patches. I2P: https://groups.google.com/a/chromium.org/g/blink-dev/c/um-9YjJWyEQ/m/MhKN0L7FAgAJ Spec PRs: HTML: whatwg/html#10869 DOM: whatwg/dom#1341 [1]: whatwg/html#10854 Bug: 409577162 Change-Id: Ieee709ff15c13bdd0b1d7598e27031867062b592 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6443776 Reviewed-by: David Baron <[email protected]> Commit-Queue: Keith Cirkel <[email protected]> Commit-Queue: David Baron <[email protected]> Auto-Submit: Keith Cirkel <[email protected]> Cr-Commit-Position: refs/heads/main@{#1446589} -- wpt-commits: 9546e2007adb73a3545fb61a5e5c8f754c6587e4 wpt-pr: 51977

…egistry and custom-element-registry into registries, a=testonly Automatic update from web-platform-tests custom-elements: merge revamped-scoped-registry and custom-element-registry into registries And rename away from .tentative for the Revamped Scoped Custom Element Registry tests as whatwg/html#10869 and whatwg/dom#1341 are about to land. -- wpt-commits: 7087b359a1e2e306db934e5ff11218bd871cb228 wpt-pr: 51953

…ed registry, a=testonly Automatic update from web-platform-tests Scaffold out basic IDL for revamped scoped registry This implements the IDL definitions per the spec issue[1], however all methods are basic stubs and do not execute any logic - the logic will come with later patches. I2P: https://groups.google.com/a/chromium.org/g/blink-dev/c/um-9YjJWyEQ/m/MhKN0L7FAgAJ Spec PRs: HTML: whatwg/html#10869 DOM: whatwg/dom#1341 [1]: whatwg/html#10854 Bug: 409577162 Change-Id: Ieee709ff15c13bdd0b1d7598e27031867062b592 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6443776 Reviewed-by: David Baron <[email protected]> Commit-Queue: Keith Cirkel <[email protected]> Commit-Queue: David Baron <[email protected]> Auto-Submit: Keith Cirkel <[email protected]> Cr-Commit-Position: refs/heads/main@{#1446589} -- wpt-commits: 9546e2007adb73a3545fb61a5e5c8f754c6587e4 wpt-pr: 51977

annevk added a commit to whatwg/html that referenced this pull request Dec 17, 2024

Add Scoped Custom Element Registries

9aecb05

Do not comment directly on this PR while it is in draft state. Use #10854 instead. DOM PR: whatwg/dom#1341. Tests: ...

This was referenced Dec 17, 2024

Add Scoped Custom Element Registries whatwg/html#10869

Merged

Revamped Scoped Custom Element Registries whatwg/html#10854

Closed

annevk marked this pull request as ready for review December 19, 2024 09:51

annevk added topic: custom elements Relates to custom elements (as defined in DOM and HTML) addition/proposal New features or enhancements topic: shadow Relates to shadow trees (as defined in DOM) topic: nodes labels Dec 19, 2024

annevk force-pushed the annevk/scoped-custom-element-registries branch from 66f3a02 to dacf095 Compare December 19, 2024 10:05

annevk added a commit to whatwg/html that referenced this pull request Dec 19, 2024

Add Scoped Custom Element Registries

3ad2431

DOM PR: whatwg/dom#1341. Tests: ... Closes #10854.

annevk force-pushed the annevk/scoped-custom-element-registries branch from dacf095 to 7e04bae Compare February 21, 2025 09:40

annevk added a commit to whatwg/html that referenced this pull request Feb 21, 2025

Add Scoped Custom Element Registries

2a6fa8f

DOM PR: whatwg/dom#1341. Tests: ... Closes #10854.

annevk mentioned this pull request Feb 21, 2025

Scoped Custom Element Registries mdn/content#38266

Open

annevk added a commit to web-platform-tests/wpt that referenced this pull request Feb 21, 2025

DOM: rename importNode()'s deep to selfOnly (and invert its value)

666cc13

Part of whatwg/dom#1341.

annevk mentioned this pull request Feb 21, 2025

DOM: rename importNode()'s deep to selfOnly (and invert its value) web-platform-tests/wpt#50860

Merged

annevk added a commit to web-platform-tests/wpt that referenced this pull request Feb 22, 2025

DOM: rename importNode()'s deep to selfOnly (and invert its value)

5bcf44c

Part of whatwg/dom#1341.

rniwa mentioned this pull request Feb 25, 2025

Sessions for March 26th W3C Breakout Day 2025 WICG/webcomponents#1095

Open

annevk added a commit to web-platform-tests/wpt that referenced this pull request Feb 25, 2025

DOM: createElement and createElementNS with scoped registries

197e5ea

For whatwg/dom#1341.

annevk mentioned this pull request Feb 25, 2025

DOM: createElement and createElementNS with scoped registries web-platform-tests/wpt#50925

Merged

annevk added a commit to web-platform-tests/wpt that referenced this pull request Feb 25, 2025

DOM: createElement and createElementNS with scoped registries

a52f979

For whatwg/dom#1341.

This was linked to issues Feb 26, 2025

Revamped Scoped Custom Element Registries (DOM side) #1339

Closed

Revamped Scoped Custom Element Registries whatwg/html#10854

Closed

foolip reviewed Mar 20, 2025

View reviewed changes

annevk added 2 commits April 7, 2025 15:47

Add Scoped Custom Element Registries

bf54001

HTML PR: whatwg/html#10869. Tests: ... Closes #1339.

review feedback part 1

595a156

annevk force-pushed the annevk/scoped-custom-element-registries branch from 5a1943c to 595a156 Compare April 7, 2025 13:55

annevk added 3 commits April 7, 2025 16:00

clash with epub

e6df8ef

define Document's custom element registry

35be566

nit

2ff2920

annevk added a commit to whatwg/html that referenced this pull request Apr 7, 2025

Add Scoped Custom Element Registries

35058f0

DOM PR: whatwg/dom#1341. Tests: ... Closes #10854.

foolip approved these changes Apr 10, 2025

View reviewed changes

annevk mentioned this pull request Apr 11, 2025

custom-elements: merge revamped-scoped-registry and custom-element-registry into registries web-platform-tests/wpt#51953

Merged

annevk added a commit to whatwg/html that referenced this pull request Apr 14, 2025

Add Scoped Custom Element Registries

f2d8b88

DOM PR: whatwg/dom#1341. Tests: web-platform-tests/wpt#50790 & and others & web-platform-tests/wpt#51953. Closes #10854.

use actual references now that the HTML side landed

a77c2b8

keithamus reviewed Apr 14, 2025

View reviewed changes

annevk merged commit 388779b into main Apr 14, 2025
2 checks passed

annevk deleted the annevk/scoped-custom-element-registries branch April 14, 2025 15:51

chromium-wpt-export-bot mentioned this pull request Apr 14, 2025

Scaffold out basic IDL for revamped scoped registry web-platform-tests/wpt#51977

Merged

AtkinsSJ mentioned this pull request Apr 23, 2025

WhatPR diff viewer is broken for IDL changes whatwg/meta#348

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Scoped Custom Element Registries #1341

Add Scoped Custom Element Registries #1341

annevk commented Dec 17, 2024 •

edited by pr-preview bot

Loading

foolip left a comment

foolip Mar 20, 2025

annevk Apr 7, 2025

foolip Mar 20, 2025

keithamus Apr 14, 2025

annevk Apr 14, 2025

	<p>To <dfn>create an element internal</dfn> given a <a for=/>document</a> <var>document</var>, an
	<p>To <dfn noexport>create an element internal</dfn> given a <a for=/>document</a> <var>document</var>, an

Add Scoped Custom Element Registries #1341

Add Scoped Custom Element Registries #1341

Conversation

annevk commented Dec 17, 2024 • edited by pr-preview bot Loading

foolip left a comment

Choose a reason for hiding this comment

foolip Mar 20, 2025

Choose a reason for hiding this comment

annevk Apr 7, 2025

Choose a reason for hiding this comment

foolip Mar 20, 2025

Choose a reason for hiding this comment

keithamus Apr 14, 2025

Choose a reason for hiding this comment

annevk Apr 14, 2025

Choose a reason for hiding this comment

annevk commented Dec 17, 2024 •

edited by pr-preview bot

Loading