Define an optional value and use it for setting dialog returnValue #11280
+16
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Define a new 'optional value' for buttons and submit inputs, this is used instead of 'value' when setting a dialog's returnValue.
|
@annevk hopefully this is roughly what you had in mind? |
6 tasks
annevk
reviewed
May 2, 2025
Add submit button check. ought to be used*
lukewarlow
force-pushed
the
form-submit-returnvalue-fix
branch
from
a54c9f8 to
cadc51c
Compare
annevk
approved these changes
May 12, 2025
Comment on lines
+51413
to
+51415
| <p>The element's <span data-x="concept-fe-optional-value">optional value</span> is the value of | ||
| the element's <code data-x="attr-button-value">value</code> attribute, if there is one, or null | ||
| otherwise.</p> |
There was a problem hiding this comment.
Suggested change
| <p>The element's <span data-x="concept-fe-optional-value">optional value</span> is the value of | |
| the element's <code data-x="attr-button-value">value</code> attribute, if there is one, or null | |
| otherwise.</p> | |
| <p>The element's <span data-x="concept-fe-optional-value">optional value</span> is the value of | |
| the element's <code data-x="attr-button-value">value</code> attribute, if there is one; otherwise | |
| null.</p> |
Comment on lines
+53872
to
53875
| data-x="attr-button-value">value</code> attribute, if there is one, or the empty string otherwise. | ||
| The element's <span data-x="concept-fe-optional-value">optional value</span> is the value of the | ||
| element's <code data-x="attr-button-value">value</code> attribute, if there is one, or null | ||
| otherwise.</p> |
There was a problem hiding this comment.
Suggested change
| data-x="attr-button-value">value</code> attribute, if there is one, or the empty string otherwise. | |
| The element's <span data-x="concept-fe-optional-value">optional value</span> is the value of the | |
| element's <code data-x="attr-button-value">value</code> attribute, if there is one, or null | |
| otherwise.</p> | |
| data-x="attr-button-value">value</code> attribute, if there is one; otherwise the empty string. | |
| The element's <span data-x="concept-fe-optional-value">optional value</span> is the value of the | |
| element's <code data-x="attr-button-value">value</code> attribute, if there is one; otherwise | |
| null.</p> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define a new 'optional value' for buttons and submit inputs, this is used instead of 'value' when setting a dialog's returnValue.
Fixes #11092
(See WHATWG Working Mode: Changes for more details.)
/form-control-infrastructure.html ( diff )
/form-elements.html ( diff )
/input.html ( diff )
/interactive-elements.html ( diff )