Skip to content

Define an optional value and use it for setting dialog returnValue #11280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Define an optional value and use it for setting dialog returnValue #11280

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab7246d
Define an optional value and use it for setting dialog returnValue
lukewarlow May 1, 2025
cadc51c
Address comments
lukewarlow May 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions source
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51410,6 +51410,10 @@ ldh-str = &lt; as defined in <a href="https://www.rfc-editor.org/rfc/rfc10

<div w-nodev>

<p>The element's <span data-x="concept-fe-optional-value">optional value</span> is the value of
the element's <code data-x="attr-button-value">value</code> attribute, if there is one, or null
otherwise.</p>
Comment on lines +51413 to +51415
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<p>The element's <span data-x="concept-fe-optional-value">optional value</span> is the value of
the element's <code data-x="attr-button-value">value</code> attribute, if there is one, or null
otherwise.</p>
<p>The element's <span data-x="concept-fe-optional-value">optional value</span> is the value of
the element's <code data-x="attr-button-value">value</code> attribute, if there is one; otherwise
null.</p>


<p>The element's <span>input activation behavior</span> given <var>event</var> is as follows:</p>

<ol>
Expand Down Expand Up @@ -53865,7 +53869,9 @@ interface <dfn interface>HTMLButtonElement</dfn> : <span>HTMLElement</span> {
<p>The <dfn element-attr for="button"><code data-x="attr-button-value">value</code></dfn>
attribute gives the element's value for the purposes of form submission. The element's <span
data-x="concept-fe-value">value</span> is the value of the element's <code
data-x="attr-button-value">value</code> attribute, if there is one, or the empty string
data-x="attr-button-value">value</code> attribute, if there is one, or the empty string otherwise.
The element's <span data-x="concept-fe-optional-value">optional value</span> is the value of the
element's <code data-x="attr-button-value">value</code> attribute, if there is one, or null
otherwise.</p>
Comment on lines +53872 to 53875
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
data-x="attr-button-value">value</code> attribute, if there is one, or the empty string otherwise.
The element's <span data-x="concept-fe-optional-value">optional value</span> is the value of the
element's <code data-x="attr-button-value">value</code> attribute, if there is one, or null
otherwise.</p>
data-x="attr-button-value">value</code> attribute, if there is one; otherwise the empty string.
The element's <span data-x="concept-fe-optional-value">optional value</span> is the value of the
element's <code data-x="attr-button-value">value</code> attribute, if there is one; otherwise
null.</p>


<p class="note">A button (and its value) is only included in the form submission if the button
Expand Down Expand Up @@ -56648,6 +56654,11 @@ interface <dfn interface>HTMLLegendElement</dfn> : <span>HTMLElement</span> {
default value. If it is false, <span data-x="concept-fe-value">value</span> mirrors the default
value. If it is true, the default value is ignored.</p>

<p>Some form controls also have an <dfn data-x="concept-fe-optional-value">optional value</dfn>
this largely mirrors the <span data-x="concept-fe-value">value</span> but doesn't normalize to an
empty string. <span class="note">This ought to be used sparingly, you generally want <span
data-x="concept-fe-value">value</span></span>.</p>

<p><code>input</code>, <code>textarea</code>, and <code>select</code> elements have a
<dfn>user validity</dfn> boolean. It is initially set to false.</p>

Expand Down Expand Up @@ -60398,8 +60409,9 @@ fur
</ol>
</li>

<li><p>Otherwise, if <var>submitter</var> has a <span data-x="concept-fe-value">value</span>,
then set <var>result</var> to that <span data-x="concept-fe-value">value</span>.</p></li>
<li><p>Otherwise, if <var>submitter</var> is a <span data-x="concept-submit-button">submit
button</span>, then set <var>result</var> to <var>submitter</var>'s <span
data-x="concept-fe-optional-value">optional value</span>.</p></li>

<li><p><span>Close the dialog</span> <var>subject</var> with <var>result</var>.</p></li>

Expand Down Expand Up @@ -62609,7 +62621,7 @@ interface <dfn interface>HTMLDialogElement</dfn> : <span>HTMLElement</span> {

<ol>
<li><p>Let <var>value</var> be <var>invoker</var>'s <span
data-x="concept-fe-value">value</span>.</p></li>
data-x="concept-fe-optional-value">optional value</span>.</p></li>

<li><p><span>Close the dialog</span> <var>element</var> with <var>value</var>.</p></li>
</ol>
Expand Down