fix(ci): retry tagged releases on Node 24 - #27
Conversation
Deploying restty with
|
| Latest commit: |
4a9dc41
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://95c9414a.restty.pages.dev |
| Branch Preview URL: | https://agent-retry-tagged-releases.restty.pages.dev |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4a9dc41c19
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| concurrency: | ||
| group: release-${{ github.ref }} | ||
| group: release-${{ inputs.tag || github.ref }} |
There was a problem hiding this comment.
Normalize the release concurrency key
In this workflow, a tag push for v0.2.1 resolves this group to release-refs/tags/v0.2.1, while the manual retry added here with input v0.2.1 resolves to release-v0.2.1; because cancel-in-progress: false only serializes runs with the same group, dispatching a retry while the tag-push run is still pending or running can let both runs reach npm publish/GitHub release creation for the same version concurrently. Use the same normalized tag value for both triggers.
Useful? React with 👍 / 👎.
Summary
npm@latestsatisfies its engine requirementsRoot cause
The
v0.2.1release validation passed, but the publish job used Node 20 and attempted to install npm 12.0.1. npm 12 requires Node 22.22.2 or Node 24.15.0 and rejected the runner before package installation.Validation
.github/workflows/publish.ymlwith the installed YAML parsergit diff --checkv0.2.1is an annotated tagAfter merge, the workflow will be dispatched for the existing
v0.2.1tag.