Skip to content

fix(ci): retry tagged releases on Node 24 #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wiedymi merged 1 commit into from
Jul 16, 2026
Merged

fix(ci): retry tagged releases on Node 24 #27

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 25 additions & 13 deletions .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,22 @@ on:
push:
tags:
- "v*.*.*"
workflow_dispatch:
inputs:
tag:
description: "Existing annotated release tag to publish"
required: true
type: string

env:
RELEASE_TAG: ${{ inputs.tag || github.ref_name }}

permissions:
contents: write
id-token: write

concurrency:
group: release-${{ github.ref }}
group: release-${{ inputs.tag || github.ref }}

@chatgpt-codex-connector chatgpt-codex-connector Bot Jul 16, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Normalize the release concurrency key

In this workflow, a tag push for v0.2.1 resolves this group to release-refs/tags/v0.2.1, while the manual retry added here with input v0.2.1 resolves to release-v0.2.1; because cancel-in-progress: false only serializes runs with the same group, dispatching a retry while the tag-push run is still pending or running can let both runs reach npm publish/GitHub release creation for the same version concurrently. Use the same normalized tag value for both triggers.

Useful? React with 👍 / 👎.

cancel-in-progress: false

jobs:
Expand All @@ -23,6 +32,7 @@ jobs:
- name: Checkout
uses: actions/checkout@v4
with:
ref: ${{ env.RELEASE_TAG }}
submodules: recursive
fetch-depth: 0

Expand All @@ -33,12 +43,12 @@ jobs:

- name: Verify annotated release tag
run: |
git fetch --force origin "refs/tags/$GITHUB_REF_NAME:refs/tags/$GITHUB_REF_NAME"
git fetch --force origin "refs/tags/$RELEASE_TAG:refs/tags/$RELEASE_TAG"

TAG_REF="refs/tags/$GITHUB_REF_NAME"
TAG_REF="refs/tags/$RELEASE_TAG"
TAG_TYPE="$(git cat-file -t "$TAG_REF")"
if [ "$TAG_TYPE" != "tag" ]; then
echo "Release tags must be annotated. Use: git tag -a $GITHUB_REF_NAME -m $GITHUB_REF_NAME"
echo "Release tags must be annotated. Use: git tag -a $RELEASE_TAG -m $RELEASE_TAG"
exit 1
fi

Expand All @@ -54,15 +64,15 @@ jobs:

- name: Verify tag matches package version
run: |
VERSION="${GITHUB_REF_NAME#v}"
VERSION="${RELEASE_TAG#v}"
PACKAGE_VERSION="$(bun -e "console.log((await Bun.file('package.json').json()).version)")"
if [ "$PACKAGE_VERSION" != "$VERSION" ]; then
echo "Tag version $VERSION does not match package.json version $PACKAGE_VERSION"
exit 1
fi

- name: Verify changelog release notes
run: bun run scripts/extract-changelog-release-notes.ts "${GITHUB_REF_NAME#v}" /tmp/release-notes.md
run: bun run scripts/extract-changelog-release-notes.ts "${RELEASE_TAG#v}" /tmp/release-notes.md

- name: Verify generated themes
run: bun run check:themes
Expand Down Expand Up @@ -92,6 +102,7 @@ jobs:
- name: Checkout
uses: actions/checkout@v4
with:
ref: ${{ env.RELEASE_TAG }}
submodules: recursive
fetch-depth: 0

Expand All @@ -103,7 +114,7 @@ jobs:
- name: Setup Node.js for npm
uses: actions/setup-node@v4
with:
node-version: 20
node-version: 24
registry-url: "https://registry.npmjs.org/"

- name: Upgrade npm for trusted publishing
Expand All @@ -130,6 +141,7 @@ jobs:
- name: Checkout
uses: actions/checkout@v4
with:
ref: ${{ env.RELEASE_TAG }}
fetch-depth: 0

- name: Setup Bun
Expand All @@ -138,21 +150,21 @@ jobs:
bun-version: latest

- name: Extract changelog release notes
run: bun run scripts/extract-changelog-release-notes.ts "${GITHUB_REF_NAME#v}" RELEASE_NOTES.md
run: bun run scripts/extract-changelog-release-notes.ts "${RELEASE_TAG#v}" RELEASE_NOTES.md

- name: Create GitHub Release
env:
GH_TOKEN: ${{ github.token }}
run: |
if gh release view "$GITHUB_REF_NAME" >/dev/null 2>&1; then
gh release edit "$GITHUB_REF_NAME" \
--title "$GITHUB_REF_NAME" \
if gh release view "$RELEASE_TAG" >/dev/null 2>&1; then
gh release edit "$RELEASE_TAG" \
--title "$RELEASE_TAG" \
--notes-file RELEASE_NOTES.md \
--latest \
--verify-tag
else
gh release create "$GITHUB_REF_NAME" \
--title "$GITHUB_REF_NAME" \
gh release create "$RELEASE_TAG" \
--title "$RELEASE_TAG" \
--notes-file RELEASE_NOTES.md \
--latest \
--verify-tag
Expand Down
Loading