Adding base urls for Api's to App Configuration#70
Merged
willvelida merged 2 commits intomainfrom Jul 12, 2025
Merged
Conversation
Signed-off-by: Will Velida <willvelida@hotmail.co.uk>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds dedicated App Configuration entries for the base URLs of the Activity, Sleep, and Weight APIs, improving endpoint manageability.
- Introduce a Bicep variable for each API's configuration key name.
- Create a new
Microsoft.AppConfiguration/configurationStores/keyValuesresource to store each API’s gateway URL. - Consistently reference
${apim.properties.gatewayUrl}/<api>for each endpoint.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| infra/apps/activity-api/main.bicep | Added activityApiEndpointConfigName variable and key-value resource for Activity API base URL |
| infra/apps/sleep-api/main.bicep | Added sleepApiEndpointConfigName variable and key-value resource for Sleep API base URL |
| infra/apps/weight-api/main.bicep | Added weightApiEndpointConfigName variable and key-value resource for Weight API base URL |
Comments suppressed due to low confidence (1)
| } | ||
| } | ||
|
|
||
| resource weightApiEndpointSetting 'Microsoft.AppConfiguration/configurationStores/keyValues@2025-02-01-preview' = { |
There was a problem hiding this comment.
[nitpick] Consider specifying the contentType property (e.g., 'text/plain') for App Configuration key-values to make the data type explicit and improve downstream parsing.
Signed-off-by: Will Velida <willvelida@hotmail.co.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces configuration updates across multiple APIs (
activity-api,sleep-api, andweight-api) to define endpoint settings in Azure App Configuration. These changes ensure each API has a dedicated key-value entry for its base URL, enhancing manageability and consistency.Configuration Updates for API Endpoints:
Activity API:
activityApiEndpointConfigNameto define the key name for the API's base URL in Azure App Configuration. (infra/apps/activity-api/main.bicep, infra/apps/activity-api/main.bicepR48)activityApiEndpointSettingin Azure App Configuration to store the base URL for the Activity API (${apim.properties.gatewayUrl}/activity). (infra/apps/activity-api/main.bicep, infra/apps/activity-api/main.bicepR179-R187)Sleep API:
sleepApiEndpointConfigNameto define the key name for the API's base URL in Azure App Configuration. (infra/apps/sleep-api/main.bicep, infra/apps/sleep-api/main.bicepR48)sleepApiEndpointSettingin Azure App Configuration to store the base URL for the Sleep API (${apim.properties.gatewayUrl}/sleep). (infra/apps/sleep-api/main.bicep, infra/apps/sleep-api/main.bicepR179-R186)Weight API:
weightApiEndpointConfigNameto define the key name for the API's base URL in Azure App Configuration. (infra/apps/weight-api/main.bicep, infra/apps/weight-api/main.bicepR48)weightApiEndpointSettingin Azure App Configuration to store the base URL for the Weight API (${apim.properties.gatewayUrl}/weight). (infra/apps/weight-api/main.bicep, infra/apps/weight-api/main.bicepR177-R184)