Skip to content

Adding base urls for Api's to App Configuration #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
willvelida merged 2 commits into from
Jul 12, 2025
Merged

Adding base urls for Api's to App Configuration #70

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5cbbaa0
Adding base urls for Api's to App Configuration
willvelida Jul 12, 2025
de12092
Reverting to consistent naming format for config settings
willvelida Jul 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions infra/apps/activity-api/main.bicep
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ resource apim 'Microsoft.ApiManagement/service@2024-06-01-preview' existing = {
}

var apiProductName = 'Activity'
var activityApiEndpointConfigName = 'ActivityApi:BaseUrl'

module activityApi '../../modules/host/container-app-http.bicep' = {
name: 'activity-api'
Expand Down Expand Up @@ -175,3 +176,12 @@ module activityApiProduct '../../modules/apim/apim-products.bicep' = {
apiName: activityApimApi.name
}
}


resource activityApiEndpointSetting 'Microsoft.AppConfiguration/configurationStores/keyValues@2025-02-01-preview' = {
name: activityApiEndpointConfigName
parent: appConfig
properties: {
value: '${apim.properties.gatewayUrl}/activity'
}
}
9 changes: 9 additions & 0 deletions infra/apps/sleep-api/main.bicep
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ resource apim 'Microsoft.ApiManagement/service@2024-06-01-preview' existing = {
}

var apiProductName = 'Sleep'
var sleepApiEndpointConfigName = 'SleepApi:BaseUrl'

module sleepApi '../../modules/host/container-app-http.bicep' = {
name: 'sleep-api'
Expand Down Expand Up @@ -175,3 +176,11 @@ module sleepApiProduct '../../modules/apim/apim-products.bicep' = {
productName: apiProductName
}
}

resource sleepApiEndpointSetting 'Microsoft.AppConfiguration/configurationStores/keyValues@2025-02-01-preview' = {
name: sleepApiEndpointConfigName
parent: appConfig
properties: {
value: '${apim.properties.gatewayUrl}/sleep'
}
}
9 changes: 9 additions & 0 deletions infra/apps/weight-api/main.bicep
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ resource apim 'Microsoft.ApiManagement/service@2024-06-01-preview' existing = {
}

var apiProductName = 'Weight'
var weightApiEndpointConfigName = 'WeightApi:BaseUrl'

module weightApi '../../modules/host/container-app-http.bicep' = {
name: 'weight-api'
Expand Down Expand Up @@ -173,3 +174,11 @@ module weightApiProduct '../../modules/apim/apim-products.bicep' = {
productName: apiProductName
}
}

resource weightApiEndpointSetting 'Microsoft.AppConfiguration/configurationStores/keyValues@2025-02-01-preview' = {
Copy link

Copilot AI Jul 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider specifying the contentType property (e.g., 'text/plain') for App Configuration key-values to make the data type explicit and improve downstream parsing.

Copilot uses AI. Check for mistakes.
name: weightApiEndpointConfigName
parent: appConfig
properties: {
value: '${apim.properties.gatewayUrl}/weight'
}
}
Loading