fix: populate release cache on 'show' for non-installed packages#1848
Merged
philclifford merged 1 commit intowimpysworld:mainfrom Apr 21, 2026
Merged
Conversation
Since wimpysworld#1419, get_github_releases, get_gitlab_releases, and get_website only refresh their cache files for 'install', 'fix-installed', or 'update' (the latter only when the package is installed). As a result, 'deb-get show <pkg>' on a non-installed package that uses one of those sources prints empty Published and Download lines — the per-package script reads the cache to derive URL and VERSION_PUBLISHED, but the cache was never fetched. Adding 'show' to the action allowlist keeps the 'no cache for apps we never install' intent in place (no change for list/prettylist/etc) while making sure 'show' returns a complete record for any supported package. Closes wimpysworld#1842
Contributor
There was a problem hiding this comment.
No issues found across 1 file
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Auto-approved: Trivial fix adding 'show' to an allowlist for metadata cache population, resolving a UI issue with empty fields for non-installed packages.
Contributor
Author
|
Thanks for the merge, @philclifford. Caching on show makes the UX a lot snappier. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1842
Problem
deb-get show <pkg>prints emptyPublished:andDownload:lines when the package is not installed and usesget_github_releases,get_gitlab_releases, orget_website:Per-package scripts like
01-main/packages/gb-studioderiveURLandVERSION_PUBLISHEDby reading${CACHE_FILE}, but since #1419 the cache is only populated forinstall,fix-installed, andupdate(the latter only when the package is already installed).showwas not in that allowlist, so for non-installed packages the cache file never existed, the grep in the package definition returned nothing, and the two lines came out blank.Fix
Add
showto the action allowlist inget_github_releases,get_gitlab_releases, andget_website. The existing "no cache for apps we never install" guarantee (no fetching duringlist,prettylist,csvlist,search, etc.) is preserved.Testing
bash -n deb-getpasses${ACTION}; the same pattern is applied consistently across all threeScope notes
list,prettylist,csvlist,search,remove,purge— cache is still not fetched during those actionsdirectsources — they do not depend on the cache fileDEBGET_CACHE_RTN) still applies, so repeatedshowcalls won't hammer GitHub / GitLab APIs