forked from ppy/osu
-
Notifications
You must be signed in to change notification settings - Fork 0
Adopt winnerspiros forks v2026.421.1, sync ppy/osu, document ANGLE on Android #223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
8bae626
Fix build: use official ppy.osu.Framework.Android/iOS 2026.416.0 (ppy…
Copilot 92c97da
Revert "Fix build: use official ppy.osu.Framework.Android/iOS 2026.41…
Copilot 4f02594
Hide beatmap download notification in ranked play (#37444)
smoogipoo b398774
Disable discord invites for ranked play (#37439)
zihadmahiuddin 1925fff
Bump framework to 2026.421.1 and expose CustomDrawLimit slider
Copilot 798709e
Merge ppy/osu master: ranked-play fixes (#37439, #37444)
Copilot 74e657b
Merge ppy/osu master and refresh README with fork 2026.421.1 adoption…
Copilot 439f7e9
Fix CI NU1603 errors by pinning ppy.Veldrid.SPIRV transitive dependency
Copilot 01768a7
Use 16 KB-aligned ppy.Veldrid.SPIRV fork build via local-packages
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CreateChildDependencies() builds BeatmapModelDownloader using parent.Get<…>(). This bypasses any overrides/caches added by base.CreateChildDependencies(parent) (for example, tests can cache a dummy IAPIProvider in the child container). It can also lead to BeatmapModelDownloader using a different BeatmapManager/IAPIProvider than the ones resolved into this drawable. Use the base child container (or the new
dependenciescontainer) to resolve BeatmapManager/IAPIProvider instead ofparentwhen constructing the downloader.