Fix Android startup crash in VulkanRenderer - #80
Conversation
The `VulkanRenderer::chooseSwapExtent` method in `vulkan_renderer.cpp` was calling `ANativeWindow_getWidth` and `ANativeWindow_getHeight` but discarding their return values. This resulted in `width` and `height` variables remaining uninitialized, leading to undefined behavior (likely garbage values) when creating the Vulkan swapchain. This change captures the return values correctly. Additionally, `JNI_OnLoad` has been marked with `JNIEXPORT` and a log message added to ensure proper visibility and easier debugging of JVM initialization.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
Fixes a critical startup crash on Android devices where
VulkanRendererwould use uninitialized memory for swapchain dimensions.osu.Android/Native/vulkan_renderer.cpp:ANativeWindow_getWidth/Height.JNIEXPORTand logging toJNI_OnLoad.PR created automatically by Jules for task 1345616918090383590 started by @winnerspiros