Skip to content

Fix Android startup crash in VulkanRenderer #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
winnerspiros merged 1 commit into from
Feb 9, 2026
Merged

Fix Android startup crash in VulkanRenderer #80

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions osu.Android/Native/vulkan_renderer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,9 @@

static JavaVM* g_vm = nullptr;

jint JNI_OnLoad(JavaVM* vm, void* reserved) {
JNIEXPORT jint JNI_OnLoad(JavaVM* vm, void* reserved) {
g_vm = vm;
LOGI("JNI_OnLoad called, JVM initialized");
return JNI_VERSION_1_6;
}

Expand Down Expand Up @@ -358,9 +359,8 @@ VkExtent2D VulkanRenderer::chooseSwapExtent(const VkSurfaceCapabilitiesKHR& capa
if (capabilities.currentExtent.width != UINT32_MAX) {
return capabilities.currentExtent;
} else {
int width, height;
ANativeWindow_getWidth(window);
ANativeWindow_getHeight(window);
int width = ANativeWindow_getWidth(window);
int height = ANativeWindow_getHeight(window);

VkExtent2D actualExtent = {
static_cast<uint32_t>(width),
Expand Down