Skip to content

feat: add GitHub Actions workflow for Testservice docker publishing#3759

Closed
MohamadJaara wants to merge 1 commit into
developfrom
mo/ci/publish-test-service-docker
Closed

feat: add GitHub Actions workflow for Testservice docker publishing#3759
MohamadJaara wants to merge 1 commit into
developfrom
mo/ci/publish-test-service-docker

Conversation

@MohamadJaara

Copy link
Copy Markdown
Member

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Briefly describe the issue you have solved or implemented with this pull request. If the PR contains multiple issues, use a bullet list.

Causes (Optional)

Briefly describe the causes behind the issues. This could be helpful to understand the adopted solutions behind some nasty bugs or complex issues.

Solutions

Briefly describe the solutions you have implemented for the issues explained above.

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@sonarqubecloud

sonarqubecloud Bot commented Dec 8, 2025

Copy link
Copy Markdown

@github-actions

github-actions Bot commented Dec 8, 2025

Copy link
Copy Markdown
Contributor

Test Results

4 145 tests  ±0   4 034 ✅ ±0   5m 38s ⏱️ -11s
  698 suites ±0     111 💤 ±0 
  698 files   ±0       0 ❌ ±0 

Results for commit cae1bde. ± Comparison against base commit fa29fee.

♻️ This comment has been updated with latest results.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.82%. Comparing base (fa29fee) to head (cae1bde).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3759      +/-   ##
===========================================
- Coverage    59.82%   59.82%   -0.01%     
===========================================
  Files         1811     1811              
  Lines        57576    57576              
  Branches      6317     6317              
===========================================
- Hits         34446    34445       -1     
  Misses       20245    20245              
- Partials      2885     2886       +1     

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa29fee...cae1bde. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Dec 8, 2025

Copy link
Copy Markdown
Contributor

🐰 Bencher Report

Branchmo/ci/publish-test-service-docker
Testbedubuntu-latest

⚠️ WARNING: No Threshold found!

Without a Threshold, no Alerts will ever be generated.

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds flag.

Click to view all benchmark results
BenchmarkLatencymicroseconds (µs)
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles📈 view plot
⚠️ NO THRESHOLD
673.43 µs
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory📈 view plot
⚠️ NO THRESHOLD
476,748.40 µs
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark📈 view plot
⚠️ NO THRESHOLD
1,559,644.39 µs
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark📈 view plot
⚠️ NO THRESHOLD
22,520.56 µs
🐰 View full continuous benchmarking report in Bencher

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was recently aware of some security improvements we can make on Dockerfiles. https://docs.google.com/presentation/d/1oR8EB3x9LFqtY4K4neKbt9aSEwcASqf9iZuF8zvTo5k/edit?usp=sharing

I think is worth to apply, we can make @sanojwr happy :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants