Skip to content

Conversation

@florian-lefebvre
Copy link
Member

Changes

  • As a user, it can be challenging to understand why fonts may not be working
  • To help with that, we now log a warning when a remote provider returns no data for a given family

Testing

Units

Docs

Changeset

@florian-lefebvre florian-lefebvre self-assigned this May 6, 2025
@changeset-bot
Copy link

changeset-bot bot commented May 6, 2025

🦋 Changeset detected

Latest commit: 7180199

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label May 6, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented May 6, 2025

CodSpeed Performance Report

Merging #13756 will not alter performance

Comparing feat/fonts-warn-when-no-data (7180199) with main (63d60c2)

Summary

✅ 6 untouched benchmarks

Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I honestly would remove the function wrapper, it creates a further indirection, it uses "yet another pattern" that we don't use in our logging, just for a test.

@florian-lefebvre florian-lefebvre requested a review from ematipico May 6, 2025 15:41
@florian-lefebvre florian-lefebvre merged commit d4547ba into main May 6, 2025
15 checks passed
@florian-lefebvre florian-lefebvre deleted the feat/fonts-warn-when-no-data branch May 6, 2025 15:50
@astrobot-houston astrobot-houston mentioned this pull request May 6, 2025
openscript pushed a commit to openscript/astro that referenced this pull request Sep 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: astro Related to the core `astro` package (scope)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants