Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/lazy-ducks-fix.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'astro': patch
---

Adds a terminal warning when a remote provider returns no data for a family when using the experimental fonts API
11 changes: 11 additions & 0 deletions packages/astro/src/assets/fonts/orchestrate.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@ import type {
PreloadData,
} from './types.js';
import { pickFontFaceProperty, unifontFontFaceDataToProperties } from './utils.js';
import { bold } from 'kleur/colors';
import type { Logger } from '../../core/logger/core.js';

/**
* Manages how fonts are resolved:
Expand Down Expand Up @@ -54,6 +56,7 @@ export async function orchestrate({
systemFallbacksProvider,
fontMetricsResolver,
fontTypeExtractor,
logger,
createUrlProxy,
defaults,
}: {
Expand All @@ -66,6 +69,8 @@ export async function orchestrate({
systemFallbacksProvider: SystemFallbacksProvider;
fontMetricsResolver: FontMetricsResolver;
fontTypeExtractor: FontTypeExtractor;
// TODO: follow this implementation: https://github.com/withastro/astro/pull/13756/commits/e30ac2b7082a3eed36225da6e88449890cbcbe6b
logger: Logger;
createUrlProxy: (params: CreateUrlProxyParams) => UrlProxy;
defaults: Defaults;
}): Promise<{
Expand Down Expand Up @@ -163,6 +168,12 @@ export async function orchestrate({
// from families (inside extractUnifontProviders).
[family.provider.name!],
);
if (result.fonts.length === 0) {
logger.warn(
'assets',
`No data found for font family ${bold(family.name)}. Review your configuration`,
);
}
// The data returned by the remote provider contains original URLs. We proxy them.
fonts = normalizeRemoteFontFaces({ fonts: result.fonts, urlProxy });
}
Expand Down
1 change: 1 addition & 0 deletions packages/astro/src/assets/fonts/vite-plugin-fonts.ts
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,7 @@ export function fontsPlugin({ settings, sync, logger }: Options): Plugin {
systemFallbacksProvider,
fontMetricsResolver,
fontTypeExtractor,
logger,
createUrlProxy: ({ local, ...params }) => {
const dataCollector = createDataCollector(params);
const contentResolver = local
Expand Down