Skip to content

feat(fonts): add note about google options #11484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

florian-lefebvre
Copy link
Member

Description (required)

Adds a note about google options

Related issues & labels (optional)

  • Closes #
  • Suggested label:

For Astro version: 5.7.5. See astro PR: withastro/astro#13654

Copy link

netlify bot commented Apr 18, 2025

Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit f40b757
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/680275c7b88b9d0008c1a4e9
😎 Deploy Preview https://deploy-preview-11484--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Contributor

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
en/reference/experimental-flags/fonts.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@@ -200,6 +200,8 @@ provider: fontProviders.fontsource()
provider: fontProviders.google()
```

Accepts [some options](https://github.com/unjs/unifont/blob/main/src/providers/google.ts#L10-L26).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, one issue is I don't love that this doesn't look like it's part of the tab content:

image

Since there are only a few options it accepts anyway, is there a good way to put this content right in the code block itself, and maybe not even link out? That would make it more clear that this content belongs with the Google provider, and saves people a click.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants