Skip to content

feat(fonts): add note about google options #11484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −0
Open

feat(fonts): add note about google options #11484

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/content/docs/en/reference/experimental-flags/fonts.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,8 @@ provider: fontProviders.fontsource()
provider: fontProviders.google()
```

Accepts [some options](https://github.com/unjs/unifont/blob/main/src/providers/google.ts#L10-L26).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, one issue is I don't love that this doesn't look like it's part of the tab content:

image

Since there are only a few options it accepts anyway, is there a good way to put this content right in the code block itself, and maybe not even link out? That would make it more clear that this content belongs with the Google provider, and saves people a click.


</TabItem>

</Tabs>
Expand Down