i18n(fr): update guides/content-collections and related files#13431
Conversation
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
…te-guides/content-collections
…pdate-guides/content-collections
guides/content-collections.mdxguides/content-collections and related files
ld-web
left a comment
There was a problem hiding this comment.
That's clean ! Compared to the size of modifications I didn't have to comment or suggest that much modifications.
I hope it will help !
ld-web
left a comment
There was a problem hiding this comment.
That's clean ! Compared to the size of modifications I didn't have to comment or suggest that much modifications.
I hope it will help !
Co-authored-by: ld-web <46715342+ld-web@users.noreply.github.com> Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Co-authored-by: ld-web <46715342+ld-web@users.noreply.github.com> Co-authored-by: Armand Philippot <git@armand.philippot.eu>
|
Thanks a lot for the review and the brainstorming, really helpful! 🙌🏽 I think I addressed all the feedback except the one to fix in the English version first. If the fix comes first, I'll apply it. If the approval comes first, we can fix that in a following PR! |
|
Nice ! I'll open a PR about the English version tonight then. Thanks ! |
|
Thank you again, glad to have some help with all the v6 changes! 🙌🏽 And also, for your willingness to get involved and for being nitpicky with the wording (I like that)! I'm taking this as an implicit approval because I followed each suggestions, but do not hesitate to check "Approve" in the "Files changed" tab. For English docs (not just typo), we usually expect maintainers approval (even if regular contributors approval are always helpful, because this means someone already double-checked what is being sent). But, for translations native speakers approvals are important. First, this is also a reassurance for the author of the PR (ie. did I misunderstood this or not). And mostly, if a maintainer speaking the language is not available, this gives a good clue for another maintainer this is ready and they can merge this (ie. they don't need to scroll to see the last comment, on desktop at least there is an indication in the sidebar). This can be helpful when an English PR updating the same file is ready to be merged... maybe the approved translation should be merged first to avoid checking all the changes again. I'm thinking about this because the Cloudflare integration update is soon to be outdated. 😄 (Nothing wrong! Just trying to explain how we work and why explicit approvals are important for us 😉 ) |
Description (required)
Adds changes from #12322, #13427, and #13435 to the French translation of
guides/content-collections,modules/astro-content,content-loader-reference, and to the files that required a link update.Note
integrations-reference.mdxis also updated in #13448 so we might have a Git conflictRelated issues & labels (optional)