feat: add draw.arrow primitive#193
Draft
wkentaro wants to merge 2 commits into
Draft
Conversation
3 tasks
Owner
Author
|
lint is failing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
imgviz.draw.arrow(image, yx1, yx2, fill, width=1, head_length_ratio=0.1, head_angle=30.0)and its in-place pairarrow_, drawing a shaft fromyx1(tail) toyx2(tip) with an arrowhead at the tip.±head_angle, so the geometry stays correct for any direction (the "not trivially composable" justification per ADR 0002).head_length_ratiosizes the head as a fraction of the shaft length (cv2arrowedLine'stipLengthconvention), so it stays sensible at any image scale;head_angleis the head half-angle in degrees.fillstroke color likedraw.line;yx1/yx2accept tuples/lists/arrays (ArrayLike) and are shape-validated, matchingdraw.line.Test plan
tests/unit/draw/_arrow_test.py— happy path, head-adds-over-plain-line, head-at-tip for horizontal and diagonal arrows,head_length_ratioscaling, zero-length skips head, in-place mutation, non-PIL and bad-shape guardsuv run pytest tests/unit/draw/— 47 passeduv run ruff check/uv run ruff format --check/uv run ty checkclean on touched filesCloses #152