Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced QApplication from QtWidgets by QGuiApplication from QtGui #288

Closed
wants to merge 9 commits into from

Conversation

Atlas42
Copy link

@Atlas42 Atlas42 commented May 23, 2023

When using QML the application class should be a QGuiApplication.
On targets without QtWidgets (my case on an aarch64 with a custom-build qt), the crate does not build. Replacing this class usage fixes it.

@ratijas
Copy link
Collaborator

ratijas commented Aug 17, 2023

IMHO this kind of switch should be configurable. QGuiApplication is more compatible with targets, but QApplication provides automatic style change events and other nice things. How about a cargo feature flag?

Also, your pull request contains lots of unrelated commits, please your change rebase on master.

@ratijas ratijas added C-feature-request Category: A feature request, i.e: not implemented / a PR. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. A-C++ Area: C++ glue labels Aug 17, 2023
@ratijas
Copy link
Collaborator

ratijas commented Aug 17, 2023

Also, your pull request contains lots of unrelated commits, please your change rebase on master.

oh, it's probably because you submitted this pull request from your own master branch, but you continued working on it for your own project. That doesn't work well in practice. Normally, you'd create a new branch per pull request, and only push to it those changes which you intend to land as a part of such pull request.

@Atlas42
Copy link
Author

Atlas42 commented Aug 17, 2023

Using an other pull request from another branch #294

@Atlas42 Atlas42 closed this Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-C++ Area: C++ glue C-feature-request Category: A feature request, i.e: not implemented / a PR. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants