Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced QApplication from QtWidgets by QGuiApplication from QtGui #288

Closed
wants to merge 9 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions qmetaobject/src/qtdeclarative.rs
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ cpp! {{
#include <memory>
#include <QtQuick/QtQuick>
#include <QtCore/QDebug>
#include <QtWidgets/QApplication>
#include <QtGui/QGuiApplication>
#include <QtQml/QQmlComponent>

struct SingleApplicationGuard {
Expand All @@ -47,12 +47,12 @@ cpp! {{
};

struct QmlEngineHolder : SingleApplicationGuard {
std::unique_ptr<QApplication> app;
std::unique_ptr<QGuiApplication> app;
std::unique_ptr<QQmlApplicationEngine> engine;
std::unique_ptr<QQuickView> view;

QmlEngineHolder(int &argc, char **argv)
: app(new QApplication(argc, argv))
: app(new QGuiApplication(argc, argv))
, engine(new QQmlApplicationEngine())
{}
};
Expand Down
1 change: 0 additions & 1 deletion qttypes/build.rs
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,6 @@ fn main() {
};
link_lib("Core");
link_lib("Gui");
link_lib("Widgets");
#[cfg(feature = "qtquick")]
link_lib("Quick");
#[cfg(feature = "qtquick")]
Expand Down
51 changes: 48 additions & 3 deletions qttypes/src/qtcore/qvariant.rs
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
use std::fmt;

use crate::{
cpp, cpp_class, QByteArray, QDate, QDateTime, QString, QStringList, QTime, QUrl, QVariantList,
};
use crate::{cpp, cpp_class, QByteArray, QDate, QDateTime, QString, QStringList, QTime, QUrl, QVariantList, QVariantMap};

cpp_class!(
/// Wrapper around [`QVariant`][class] class.
Expand Down Expand Up @@ -30,6 +28,42 @@ impl QVariant {
})
}

/// Wrapper around [`toDouble()`][method] method.
///
/// [method]: https://doc.qt.io/qt-5/qvariant.html#toDouble
pub fn to_double(&self) -> f64 {
cpp!(unsafe [self as "const QVariant*"] -> f64 as "double" {
return self->toDouble();
})
}

/// Wrapper around [`toMap()`][method] method.
///
/// [method]: https://doc.qt.io/qt-5/qvariant.html#toMap
pub fn to_map(&self) -> QVariantMap {
cpp!(unsafe [self as "const QVariant*"] -> QVariantMap as "QVariantMap" {
return self->toMap();
})
}

/// Wrapper around [`toList()`][method] method.
///
/// [method]: https://doc.qt.io/qt-5/qvariant.html#toList
pub fn to_list(&self) -> QVariantList {
cpp!(unsafe [self as "const QVariant*"] -> QVariantList as "QVariantList" {
return self->toList();
})
}

/// Wrapper around [`toString()`][method] method.
///
/// [method]: https://doc.qt.io/qt-5/qvariant.html#toString
pub fn to_qstring(&self) -> QString {
cpp!(unsafe [self as "const QVariant*"] -> QString as "QString" {
return self->toString();
})
}

/// Wrapper around [`userType()`][method] method.
///
/// [method]: https://doc.qt.io/qt-5/qvariant.html#userType
Expand Down Expand Up @@ -137,6 +171,17 @@ impl From<QVariantList> for QVariant {
}
}

impl From<QVariantMap> for QVariant {
/// Wrapper around [`QVariant(const QVariantMap &)`][ctor] constructor.
///
/// [ctor]: https://doc.qt.io/qt-5/qvariant.html#QVariant-22
fn from(a: QVariantMap) -> QVariant {
cpp!(unsafe [a as "QVariantMap"] -> QVariant as "QVariant" {
return QVariant(a);
})
}
}

impl From<QStringList> for QVariant {
/// Wrapper around [`QVariant(const QStringList &)`][ctor] constructor.
///
Expand Down