Remove unused variables in imx_rt.c causing multiple definition errors
#539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sysPllConfig_BOARD_BootClockRUN, usb1PllConfig_BOARD_BootClockRUN and videoPllConfig_BOARD_BootClockRUN are unused, and were causing 'multiple definition' errors as the board code generated by MCUXpresso Config Tools also contains definitions for these variables.
dgarske
approved these changes
Jan 20, 2025
Contributor
|
Contributor agreement on file. @bigbrett please finalize. Thank you |
Contributor
|
Looks good, doesn't break backwards compatibilities with the SDKs I have locally installed either. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sysPllConfig_BOARD_BootClockRUN,usb1PllConfig_BOARD_BootClockRUNandvideoPllConfig_BOARD_BootClockRUNare unused, and were causingmultiple definitionerrors when compiling the wolfBoot library into our application as the board code generated by MCUXpresso Config Tools also contains definitions for these variables.