-
Notifications
You must be signed in to change notification settings - Fork 344
libmamba/2025.01.02 package update #38633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
octo-sts
bot
commented
Jan 2, 2025
Signed-off-by: wolfi-bot <[email protected]>
Gen AI suggestions to solve the build error: Based on the error, I'll provide a detailed analysis and solution: • Detected Error: The build seems to get stuck after "using /tmp/apko-temp-4262173850/apko-x86_64.tar.gz for image layer" suggesting an issue with the CMake build process • Error Category: Build Configuration • Failure Point: CMake configuration/build step • Root Cause Analysis: • Suggested Fix:
- uses: cmake/configure
with:
opts: |
-DBUILD_LIBMAMBA="ON" \
-DBUILD_SHARED="ON" \
-DBUILD_LIBMAMBAPY="ON" \
-DBUILD_MICROMAMBA="ON" \
-DBUILD_MAMBA_PACKAGE="ON" \
-DCMAKE_BUILD_TYPE=Release \
-DCONDA_REACTIVATE_CMD="__conda_activate reactivate"
environment:
contents:
packages:
# Add these packages
- ninja
- python3-dev • Explanation:
• Additional Notes:
• References: |
its failing because the patch is not applicable anymore so we should update the patch here |
Signed-off-by: Debasish Biswas <[email protected]>
Okay the test is failing now. |
In this new version, the To address this, applying the following patch might resolve the issue by ensuring the diff --git a/libmambapy/CMakeLists.txt b/libmambapy/CMakeLists.txt
index 760dd732..47d6cf23 100644
--- a/libmambapy/CMakeLists.txt
+++ b/libmambapy/CMakeLists.txt
@@ -28,5 +28,12 @@ mamba_target_add_compile_warnings(bindings WARNING_AS_ERROR ${MAMBA_WARNING_AS_E
target_link_libraries(bindings PUBLIC pybind11::pybind11 libmamba)
set_property(TARGET bindings PROPERTY CXX_STANDARD 17)
+# Get Python site-packages directory
+execute_process(
+ COMMAND "${Python_EXECUTABLE}" -c "import site; print(site.getsitepackages()[0])"
+ OUTPUT_VARIABLE PYTHON_SITE_PACKAGES
+ OUTPUT_STRIP_TRAILING_WHITESPACE
+)
+
install(TARGETS bindings
- LIBRARY DESTINATION ${CMAKE_CURRENT_SOURCE_DIR}/libmambapy/)
+ LIBRARY DESTINATION ${PYTHON_SITE_PACKAGES}/libmambapy/) Alternatively, adding the following line in the subpackage pipeline to move the mv ${{targets.destdir}}/home/build/libmambapy/libmambapy/bindings.cpython*.so ${{targets.contextdir}}/usr/lib/python${{range.key}}/site-packages/libmambapy/ Additional Issue:The current build process only works with Python 3.13, and I was unable to configure the Python version using the CMake options. Despite trying the following options, it always defaults to Python 3.13: -DPYTHON_EXECUTABLE=/usr/bin/python${{range.key}} \
-DPython_ROOT_DIR=/usr/lib/python${{range.key}} |
See #36183 for planned mamba changes |
The previous update Pr is was also escalated, this would be similar. |
Hi @debasishbsws ! I don't think this one has been escalated, though I'm clearly aware of the problem :) If you do want to escalate it, that would help bump it in our priority queue. |
superseded by #40521 |