Mamba split #36183
Draft
Mamba split #36183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannf
force-pushed
the
mamba-split
branch
2 times, most recently
from
e81290a to
74b8acb
Compare
dannf
force-pushed
the
mamba-split
branch
2 times, most recently
from
f552075 to
41cedf2
Compare
micromamba needs this. Signed-off-by: dann frazier <[email protected]>
Signed-off-by: dann frazier <[email protected]>
dannf
added
the
approved-to-run
…2.0.5 We were tracking the date-based tags, but these tags are not always forward-moving. Switch to the semver tags instead. Now, there isn't a single stream of semver tags in this project, rather there are tags per binary - e.g. libmamba-2.0.5, libmambapy-2.0.5 and micromamba-2.0.5. These tags appear to always point to the same commit hash for each release, but I'm not sure we can assume that will always be the case. Let's just treat them as separate projects. Signed-off-by: dann frazier <[email protected]>
Signed-off-by: dann frazier <[email protected]>
|
Latest package update PR @ #36642 |
|
Also see slack thread (internal to chainguard) RE discussion static vs dynamic https://chainguard-dev.slack.com/archives/C0627BW5GLF/p1730889041303439 |
|
There is a Latest update PR #38633 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been using upstream date-based tags for our versions, but that's apparently not what those tags are for. Currently that has CI wanting to move us backwards. We should use the semver tags instead.
Since
libmamba,libmambapyandmicromambaare all tagged separately, it's not clear which tag prefix we should be using. My thought was that we should treat them as separate sources even though they are from the same repo, and even though their releases always seem to point to the same hash.If we did that, we'd build
libmambaandlibmamba-devfromlibmamba.yaml, and then havemicromamba.yaml,py3-libmambapy.yaml, andmamba-package.yamlfiles that build those binaries against the existinglibmamba-dev.But there are some problems here.
2024.10.02to2.0.4version strings, since they sort lesser. We discussed options here, and withdrawing the date-versioned apks seems like the way to go.mamba-packagedoesn't have a tag stream. I'm not sure which tag stream we should be using to build it.micromambais supposed to be statically linked, according to https://github.com/mamba-org/mamba?tab=readme-ov-file#micromamba. Ours is not, and looks like it will require some CMake work to do so.