Skip to content

new pkg: apptainer #40548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

new pkg: apptainer #40548

wants to merge 6 commits into from

Conversation

tuananh
Copy link
Contributor

@tuananh tuananh commented Jan 26, 2025

  • add squashfs-tools which is a runtime dep for apptainer
  • Need to echo a file named VERSION in order to use WOlfi's versioning (overriding in script/get-version script)

image

  • can only do dummy test + a add remote test. can't do build yet because it requires squashfs-tools

Fixes: #40414

Related:

Pre-review Checklist

For new package PRs only

  • This PR is marked as fixing a pre-existing package request bug
    • Alternatively, the PR is marked as related to a pre-existing package request bug, such as a dependency
  • REQUIRED - The package is available under an OSI-approved or FSF-approved license
  • REQUIRED - The version of the package is still receiving security updates
  • This PR links to the upstream project's support policy (e.g. endoflife.date)

For new version streams

  • The upstream project actually supports multiple concurrent versions.
  • Any subpackages include the version string in their package name (e.g. name: ${{package.name}}-compat)
  • The package (and subpackages) provides: logical unversioned forms of the package (e.g. nodejs, nodejs-lts)
  • If non-streamed package names no longer built, open PR to withdraw them (see WITHDRAWING PACKAGES)

For package updates (renames) in the base images

When updating packages part of base images (i.e. cgr.dev/chainguard/wolfi-base or ghcr.io/wolfi-dev/sdk)

  • REQUIRED cgr.dev/chainguard/wolfi-base and ghcr.io/wolfi-dev/sdk images successfully build
  • REQUIRED cgr.dev/chainguard/wolfi-base and ghcr.io/wolfi-dev/sdk contain no obsolete (no longer built) packages
  • Upon launch, does apk upgrade --latest successfully upgrades packages or performs no actions

For security-related PRs

  • The security fix is recorded in the advisories repo

For version bump PRs

  • The epoch field is reset to 0

For PRs that add patches

  • Patch source is documented

@tuananh
Copy link
Contributor Author

tuananh commented Jan 27, 2025

@kranurag7 i think it's in ready state for review. can you take a look?

@kranurag7 kranurag7 added the approved-to-run A repo member has approved this external contribution label Jan 27, 2025
@octo-sts octo-sts bot added the bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages. label Jan 27, 2025
@tuananh
Copy link
Contributor Author

tuananh commented Jan 29, 2025

@kranurag7 not sure how test fail. i tried apk add locally, run the test manually (copy the script) and it works

running make test/squashfs-tools resulted in core dump :-/

Signed-off-by: Tuan Anh Tran <[email protected]>
Signed-off-by: Tuan Anh Tran <[email protected]>
Signed-off-by: Tuan Anh Tran <[email protected]>
Signed-off-by: Tuan Anh Tran <[email protected]>
@tuananh
Copy link
Contributor Author

tuananh commented Jan 31, 2025

@kranurag7 all is good i guess :)

Copy link
Contributor

github-actions bot commented May 1, 2025

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Keep fresh with the 'lifecycle/frozen' label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved-to-run A repo member has approved this external contribution bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages. lifecycle/stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Wolfi Package Request]: Apptainer
2 participants