Issue/12918 support account creation UI changes #12935

JorgeMucientes · 2024-11-15T12:29:47Z

⚠️ Depends on the FluxC changes here: wordpress-mobile/WordPress-FluxC-Android#3110

Description

Adds the functionality to create a new WP.com account from the app when attempting to connect Jetpack and the user enters a non existing WP.com email in the login step.

Unit tests added in this PR: #12945

Testing information

In the app, login into a self hosted site (jurassic ninja site will do) without Jetpack plugin connected
Click on Jetpack activation banner
Enter an email that is not a WP.com email
Check the entered email inbox from the mobile device and click the sign up link
Finish the Jetpack installation flow successfully

If you have any doubts check the following screen recording.

The tests that have been performed

Images/gif

JetpackAccountCreationDemo.mp4

I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

dangermattic · 2024-11-15T12:32:12Z

	1 Warning
⚠️	This PR is assigned to the milestone 21.2. This milestone is due in less than 2 days. Please make sure to get it merged by then or assign it to a milestone with a later deadline.

	1 Message
📖	This PR contains changes to Tracks-related logic. Please ensure (author and reviewer) the following are completed: The tracks events must be validated in the Tracks system. Verify the internal Tracks spreadsheet has also been updated. Please consider registering any new events. The PR must be assigned the category: tracks label.

Generated by 🚫 Danger

wpmobilebot · 2024-11-15T12:36:19Z

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce-Wear Android
	Platform	⌚️ Wear OS
	Flavor	Jalapeno
	Build Type	Debug
	Commit	`e425df2`
	Direct Download	`woocommerce-wear-prototype-build-pr12935-e425df2.apk`

wpmobilebot · 2024-11-15T13:10:41Z

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce Android
	Platform	📱 Mobile
	Flavor	Jalapeno
	Build Type	Debug
	Commit	`e425df2`
	Direct Download	`woocommerce-prototype-build-pr12935-e425df2.apk`

codecov-commenter · 2024-11-15T13:16:35Z

Codecov Report

Attention: Patch coverage is 7.50000% with 37 lines in your changes missing coverage. Please review.

Project coverage is 39.66%. Comparing base (a0e116b) to head (e425df2).
Report is 13 commits behind head on trunk.

Files with missing lines	Patch %	Lines
...pack/wpcom/JetpackActivationWPComEmailViewModel.kt	0.00%	22 Missing ⚠️
...pcom/JetpackActivationMagicLinkRequestViewModel.kt	0.00%	14 Missing ⚠️
...ocommerce/android/ui/login/WPComLoginRepository.kt	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##              trunk   #12935      +/-   ##
============================================
- Coverage     39.67%   39.66%   -0.02%     
  Complexity     5955     5955              
============================================
  Files          1262     1262              
  Lines         72919    72942      +23     
  Branches       9973     9977       +4     
============================================
+ Hits          28933    28934       +1     
- Misses        41415    41437      +22     
  Partials       2571     2571

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests

wpmobilebot · 2024-11-18T15:06:14Z

Project dependencies changes

The following changes in project dependencies were detected (configuration vanillaReleaseRuntimeClasspath):

list

Upgraded Dependencies
org.wordpress.fluxc.plugins:woocommerce:trunk-3b731c31d9f8ca9765a1de9ec8d4d064b88ec30a, (changed from trunk-cc17141a0e910d5b808ba6bbfb4b7d393d3517a0)
org.wordpress.fluxc:fluxc-annotations:trunk-3b731c31d9f8ca9765a1de9ec8d4d064b88ec30a, (changed from trunk-cc17141a0e910d5b808ba6bbfb4b7d393d3517a0)
org.wordpress:fluxc:trunk-3b731c31d9f8ca9765a1de9ec8d4d064b88ec30a, (changed from trunk-cc17141a0e910d5b808ba6bbfb4b7d393d3517a0)

tree

-+--- org.wordpress:fluxc:trunk-cc17141a0e910d5b808ba6bbfb4b7d393d3517a0
-|    +--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.9.25 -> 2.0.21
-|    |    +--- org.jetbrains.kotlin:kotlin-stdlib:2.0.21 (*)
-|    |    \--- org.jetbrains.kotlin:kotlin-android-extensions-runtime:2.0.21
-|    |         \--- org.jetbrains.kotlin:kotlin-stdlib:2.0.21 (*)
-|    +--- androidx.exifinterface:exifinterface:1.0.0 -> 1.3.6
-|    |    \--- androidx.annotation:annotation:1.2.0 -> 1.8.0 (*)
-|    +--- androidx.security:security-crypto:1.0.0 -> 1.1.0-alpha03
-|    |    +--- androidx.annotation:annotation:1.1.0 -> 1.8.0 (*)
-|    |    +--- com.google.crypto.tink:tink-android:1.5.0
-|    |    \--- androidx.collection:collection:1.1.0 -> 1.4.0 (*)
-|    +--- com.squareup.okhttp3:okhttp-urlconnection:4.9.0
-|    |    +--- com.squareup.okhttp3:okhttp:4.9.0 -> 4.12.0 (*)
-|    |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.4.10 -> 1.9.10 (*)
-|    +--- com.google.code.gson:gson:2.8.5 -> 2.10.1
-|    +--- org.apache.commons:commons-text:1.10.0 (*)
-|    +--- androidx.room:room-runtime:2.6.1 (*)
-|    +--- androidx.room:room-ktx:2.6.1
-|    |    +--- androidx.room:room-common:2.6.1 (*)
-|    |    +--- androidx.room:room-runtime:2.6.1 (*)
-|    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 2.0.21 (*)
-|    |    +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.7.1 -> 1.8.1 (*)
-|    |    +--- androidx.room:room-common:2.6.1 (c)
-|    |    \--- androidx.room:room-runtime:2.6.1 (c)
-|    +--- com.google.dagger:dagger:2.51.1
-|    |    \--- javax.inject:javax.inject:1
-|    +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.8.1 (*)
-|    +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.8.1 (*)
-|    +--- org.wordpress:wellsql:2.0.0
-|    |    +--- androidx.annotation:annotation:1.2.0 -> 1.8.0 (*)
-|    |    \--- org.wordpress.wellsql:wellsql-annotations:2.0.0
-|    +--- org.wordpress.fluxc:fluxc-annotations:trunk-cc17141a0e910d5b808ba6bbfb4b7d393d3517a0
-|    +--- org.greenrobot:eventbus:3.3.1 (*)
-|    +--- org.greenrobot:eventbus-java:3.3.1
-|    +--- com.squareup.okhttp3:okhttp:4.9.0 -> 4.12.0 (*)
-|    +--- com.android.volley:volley:1.1.1 -> 1.2.0
-|    +--- androidx.paging:paging-runtime:2.1.2
-|    |    +--- androidx.paging:paging-common:2.1.2
-|    |    |    +--- androidx.annotation:annotation:1.0.0 -> 1.8.0 (*)
-|    |    |    \--- androidx.arch.core:core-common:2.0.0 -> 2.2.0 (*)
-|    |    +--- androidx.arch.core:core-runtime:2.0.0 -> 2.2.0 (*)
-|    |    +--- androidx.lifecycle:lifecycle-runtime:2.0.0 -> 2.7.0 (*)
-|    |    +--- androidx.lifecycle:lifecycle-livedata:2.0.0 -> 2.7.0 (*)
-|    |    \--- androidx.recyclerview:recyclerview:1.0.0 -> 1.3.2 (*)
-|    +--- com.goterl:lazysodium-android:5.0.2
-|    +--- net.java.dev.jna:jna:5.5.0
-|    \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.25 -> 2.0.21 (*)
++--- org.wordpress:fluxc:trunk-3b731c31d9f8ca9765a1de9ec8d4d064b88ec30a
+|    +--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.9.25 -> 2.0.21
+|    |    +--- org.jetbrains.kotlin:kotlin-stdlib:2.0.21 (*)
+|    |    \--- org.jetbrains.kotlin:kotlin-android-extensions-runtime:2.0.21
+|    |         \--- org.jetbrains.kotlin:kotlin-stdlib:2.0.21 (*)
+|    +--- androidx.exifinterface:exifinterface:1.0.0 -> 1.3.6
+|    |    \--- androidx.annotation:annotation:1.2.0 -> 1.8.0 (*)
+|    +--- androidx.security:security-crypto:1.0.0 -> 1.1.0-alpha03
+|    |    +--- androidx.annotation:annotation:1.1.0 -> 1.8.0 (*)
+|    |    +--- com.google.crypto.tink:tink-android:1.5.0
+|    |    \--- androidx.collection:collection:1.1.0 -> 1.4.0 (*)
+|    +--- com.squareup.okhttp3:okhttp-urlconnection:4.9.0
+|    |    +--- com.squareup.okhttp3:okhttp:4.9.0 -> 4.12.0 (*)
+|    |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.4.10 -> 1.9.10 (*)
+|    +--- com.google.code.gson:gson:2.8.5 -> 2.10.1
+|    +--- org.apache.commons:commons-text:1.10.0 (*)
+|    +--- androidx.room:room-runtime:2.6.1 (*)
+|    +--- androidx.room:room-ktx:2.6.1
+|    |    +--- androidx.room:room-common:2.6.1 (*)
+|    |    +--- androidx.room:room-runtime:2.6.1 (*)
+|    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.8.22 -> 2.0.21 (*)
+|    |    +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.7.1 -> 1.8.1 (*)
+|    |    +--- androidx.room:room-common:2.6.1 (c)
+|    |    \--- androidx.room:room-runtime:2.6.1 (c)
+|    +--- com.google.dagger:dagger:2.51.1
+|    |    \--- javax.inject:javax.inject:1
+|    +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.8.1 (*)
+|    +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.8.1 (*)
+|    +--- org.wordpress:wellsql:2.0.0
+|    |    +--- androidx.annotation:annotation:1.2.0 -> 1.8.0 (*)
+|    |    \--- org.wordpress.wellsql:wellsql-annotations:2.0.0
+|    +--- org.wordpress.fluxc:fluxc-annotations:trunk-3b731c31d9f8ca9765a1de9ec8d4d064b88ec30a
+|    +--- org.greenrobot:eventbus:3.3.1 (*)
+|    +--- org.greenrobot:eventbus-java:3.3.1
+|    +--- com.squareup.okhttp3:okhttp:4.9.0 -> 4.12.0 (*)
+|    +--- com.android.volley:volley:1.1.1 -> 1.2.0
+|    +--- androidx.paging:paging-runtime:2.1.2
+|    |    +--- androidx.paging:paging-common:2.1.2
+|    |    |    +--- androidx.annotation:annotation:1.0.0 -> 1.8.0 (*)
+|    |    |    \--- androidx.arch.core:core-common:2.0.0 -> 2.2.0 (*)
+|    |    +--- androidx.arch.core:core-runtime:2.0.0 -> 2.2.0 (*)
+|    |    +--- androidx.lifecycle:lifecycle-runtime:2.0.0 -> 2.7.0 (*)
+|    |    +--- androidx.lifecycle:lifecycle-livedata:2.0.0 -> 2.7.0 (*)
+|    |    \--- androidx.recyclerview:recyclerview:1.0.0 -> 1.3.2 (*)
+|    +--- com.goterl:lazysodium-android:5.0.2
+|    +--- net.java.dev.jna:jna:5.5.0
+|    \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.25 -> 2.0.21 (*)
-\--- org.wordpress.fluxc.plugins:woocommerce:trunk-cc17141a0e910d5b808ba6bbfb4b7d393d3517a0
-     +--- org.wordpress:fluxc:trunk-cc17141a0e910d5b808ba6bbfb4b7d393d3517a0 (*)
-     +--- com.google.code.gson:gson:2.8.5 -> 2.10.1
-     +--- com.google.dagger:dagger:2.51.1 (*)
-     +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.8.1 (*)
-     +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.8.1 (*)
-     +--- androidx.room:room-runtime:2.6.1 (*)
-     +--- org.wordpress:wellsql:2.0.0 (*)
-     +--- org.wordpress.fluxc:fluxc-annotations:trunk-cc17141a0e910d5b808ba6bbfb4b7d393d3517a0
-     +--- androidx.room:room-ktx:2.6.1 (*)
-     \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.25 -> 2.0.21 (*)
+\--- org.wordpress.fluxc.plugins:woocommerce:trunk-3b731c31d9f8ca9765a1de9ec8d4d064b88ec30a
+     +--- org.wordpress:fluxc:trunk-3b731c31d9f8ca9765a1de9ec8d4d064b88ec30a (*)
+     +--- com.google.code.gson:gson:2.8.5 -> 2.10.1
+     +--- com.google.dagger:dagger:2.51.1 (*)
+     +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.8.1 (*)
+     +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.8.1 (*)
+     +--- androidx.room:room-runtime:2.6.1 (*)
+     +--- org.wordpress:wellsql:2.0.0 (*)
+     +--- org.wordpress.fluxc:fluxc-annotations:trunk-3b731c31d9f8ca9765a1de9ec8d4d064b88ec30a
+     +--- androidx.room:room-ktx:2.6.1 (*)
+     \--- org.jetbrains.kotlin:kotlin-stdlib:1.9.25 -> 2.0.21 (*)

hichamboushaba

Nice work @JorgeMucientes, works well.

I left some minor comments, but nothing blocking.

WooCommerce/src/main/res/values/strings.xml

...otlin/com/woocommerce/android/ui/login/jetpack/wpcom/JetpackActivationWPComEmailViewModel.kt

...n/kotlin/com/woocommerce/android/ui/login/jetpack/wpcom/JetpackActivationWPComEmailScreen.kt

…nges

hichamboushaba · 2024-11-20T13:51:31Z

...otlin/com/woocommerce/android/ui/login/jetpack/wpcom/JetpackActivationWPComEmailViewModel.kt

+    private fun trackLoginFlowAuthOptionError(
+        failure: AuthOptionsError?,
+        isSignup: Boolean
+    ) {
+        analyticsTrackerWrapper.track(
+            JETPACK_SETUP_LOGIN_FLOW,
+            mapOf(
+                AnalyticsTracker.KEY_STEP to AnalyticsTracker.VALUE_JETPACK_SETUP_STEP_EMAIL_ADDRESS,
+                AnalyticsTracker.KEY_FAILURE to (failure?.type?.name ?: "Unknown error"),
+                AnalyticsTracker.KEY_IS_SIGN_UP to isSignup
+            )
+        )
+    }
+


@JorgeMucientes sorry for missing this during my review, I just paid attention to this while I'm working on tracks for iOS, I noticed we track the case of unknown_user as error also, is this what we wanted? I mean technically it's an error with this flow 🤔

JorgeMucientes added 2 commits November 15, 2024 12:27

Handle the case where user enters an non WP.com email

d90f0a1

Handle the case where user enters an non WP.com user account

f369a34

JorgeMucientes added 2 commits November 15, 2024 13:45

Handle the case where user enters a username instead of email

db8e144

Handle the case where user enters a username instead of email

c6b1d97

JorgeMucientes force-pushed the issue/12918-support-account-creation-ui-changes branch from 35b81b5 to c6b1d97 Compare November 15, 2024 12:51

JorgeMucientes added 3 commits November 15, 2024 15:53

Send sign up magic link if email doesn't exist

bfca393

Add tracking for Jetpack flow signup

6fc1e0a

Update fluxc changeset to latest version

beb0cc5

JorgeMucientes force-pushed the issue/12918-support-account-creation-ui-changes branch from 483781a to beb0cc5 Compare November 18, 2024 15:02

JorgeMucientes mentioned this pull request Nov 18, 2024

Updates Authenticator file to use API 1.3 for sign up links wordpress-mobile/WordPress-FluxC-Android#3110

Merged

JorgeMucientes added the type: task An internally driven task. label Nov 18, 2024

JorgeMucientes added this to the 21.2 milestone Nov 18, 2024

JorgeMucientes added feature: login Related to any part of the log in or sign in flow, or authentication. unit-tests-exemption labels Nov 18, 2024

Adds a new text to make sure user double checks the email is correct

48bc64a

JorgeMucientes added the category: tracks Related to analytics, including Tracks Events. label Nov 19, 2024

Add isSignup property when unknown user email is entered

c15b716

JorgeMucientes requested a review from hichamboushaba November 19, 2024 10:39

JorgeMucientes marked this pull request as ready for review November 19, 2024 10:39

JorgeMucientes mentioned this pull request Nov 19, 2024

Issue/12944 unit tests account creation #12945

Merged

4 tasks

hichamboushaba approved these changes Nov 19, 2024

View reviewed changes

JorgeMucientes added 3 commits November 20, 2024 11:18

Update FluxC changeset

b8904b1

Merge branch 'trunk' into issue/12918-support-account-creation-ui-cha…

0ba9f71

…nges

Remove "address" wording when referring to username

e425df2

JorgeMucientes enabled auto-merge November 20, 2024 10:22

JorgeMucientes merged commit af6879f into trunk Nov 20, 2024
13 of 15 checks passed

JorgeMucientes deleted the issue/12918-support-account-creation-ui-changes branch November 20, 2024 10:46

hichamboushaba reviewed Nov 20, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Issue/12918 support account creation UI changes #12935

Issue/12918 support account creation UI changes #12935

Uh oh!

JorgeMucientes commented Nov 15, 2024 •

edited by hichamboushaba

Loading

Uh oh!

dangermattic commented Nov 15, 2024 •

edited

Loading

Uh oh!

wpmobilebot commented Nov 15, 2024 •

edited

Loading

Uh oh!

wpmobilebot commented Nov 15, 2024 •

edited

Loading

Uh oh!

codecov-commenter commented Nov 15, 2024 •

edited

Loading

Uh oh!

wpmobilebot commented Nov 18, 2024 •

edited

Loading

Uh oh!

hichamboushaba left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hichamboushaba Nov 20, 2024 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Issue/12918 support account creation UI changes #12935

Issue/12918 support account creation UI changes #12935

Uh oh!

Conversation

JorgeMucientes commented Nov 15, 2024 • edited by hichamboushaba Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Testing information

The tests that have been performed

Images/gif

Reviewer (or Author, in the case of optional code reviews):

Uh oh!

dangermattic commented Nov 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wpmobilebot commented Nov 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wpmobilebot commented Nov 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-commenter commented Nov 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

wpmobilebot commented Nov 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Project dependencies changes

Uh oh!

hichamboushaba left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hichamboushaba Nov 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

JorgeMucientes commented Nov 15, 2024 •

edited by hichamboushaba

Loading

dangermattic commented Nov 15, 2024 •

edited

Loading

wpmobilebot commented Nov 15, 2024 •

edited

Loading

wpmobilebot commented Nov 15, 2024 •

edited

Loading

codecov-commenter commented Nov 15, 2024 •

edited

Loading

wpmobilebot commented Nov 18, 2024 •

edited

Loading

hichamboushaba Nov 20, 2024 •

edited

Loading