Skip to content

Conversation

@JorgeMucientes
Copy link
Contributor

@JorgeMucientes JorgeMucientes commented Nov 18, 2024

Closes: #12944
⚠️ Do not merge until base branch is trunk

Description

  • Adds unit tests to JetpackActivationWPComEmailViewModel
  • Removes feature flag to enable account creation during Jetpack flow

Testing information

Checking that unit tests pass should be enough. However, if you want to retest that the account creation flow works well, please follow the steps from this PR: #12935

The tests that have been performed

The above

  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.
129

@JorgeMucientes JorgeMucientes added this to the 21.2 milestone Nov 18, 2024
@JorgeMucientes JorgeMucientes added category: unit tests Related to unit testing. feature: login Related to any part of the log in or sign in flow, or authentication. labels Nov 18, 2024
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Nov 18, 2024

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit72c49b1
Direct Downloadwoocommerce-wear-prototype-build-pr12945-72c49b1.apk

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Nov 18, 2024

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit72c49b1
Direct Downloadwoocommerce-prototype-build-pr12945-72c49b1.apk

@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.76%. Comparing base (af6879f) to head (72c49b1).
Report is 8 commits behind head on trunk.

Additional details and impacted files
@@             Coverage Diff              @@
##              trunk   #12945      +/-   ##
============================================
+ Coverage     39.66%   39.76%   +0.10%     
- Complexity     5955     5961       +6     
============================================
  Files          1262     1262              
  Lines         72942    72940       -2     
  Branches       9977     9976       -1     
============================================
+ Hits          28934    29007      +73     
+ Misses        41437    41356      -81     
- Partials       2571     2577       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@JorgeMucientes JorgeMucientes force-pushed the issue/12944-unit-tests-account-creation branch from b84221a to b857504 Compare November 19, 2024 10:41
@JorgeMucientes JorgeMucientes marked this pull request as ready for review November 19, 2024 10:41
Copy link
Member

@hichamboushaba hichamboushaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for taking care of the tests @JorgeMucientes

Base automatically changed from issue/12918-support-account-creation-ui-changes to trunk November 20, 2024 10:46
# Conflicts:
#	WooCommerce/src/main/res/values/strings.xml
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is assigned to the milestone 21.2. This milestone is due in less than 2 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@JorgeMucientes JorgeMucientes merged commit 0cd474a into trunk Nov 20, 2024
15 of 16 checks passed
@JorgeMucientes JorgeMucientes deleted the issue/12944-unit-tests-account-creation branch November 20, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: unit tests Related to unit testing. feature: login Related to any part of the log in or sign in flow, or authentication.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unit tests

6 participants