-
Notifications
You must be signed in to change notification settings - Fork 136
Issue/12944 unit tests account creation #12945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue/12944 unit tests account creation #12945
Conversation
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## trunk #12945 +/- ##
============================================
+ Coverage 39.66% 39.76% +0.10%
- Complexity 5955 5961 +6
============================================
Files 1262 1262
Lines 72942 72940 -2
Branches 9977 9976 -1
============================================
+ Hits 28934 29007 +73
+ Misses 41437 41356 -81
- Partials 2571 2577 +6 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
b84221a to
b857504
Compare
hichamboushaba
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for taking care of the tests @JorgeMucientes
# Conflicts: # WooCommerce/src/main/res/values/strings.xml
Closes: #12944
⚠️ Do not merge until base branch is
trunkDescription
JetpackActivationWPComEmailViewModelTesting information
Checking that unit tests pass should be enough. However, if you want to retest that the account creation flow works well, please follow the steps from this PR: #12935
The tests that have been performed
The above
RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:
- The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
- Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
- Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.
129