Skip to content

[Shipping Labels] Enhance selected shipping package UI #14579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Sep 11, 2025
Merged

[Shipping Labels] Enhance selected shipping package UI #14579

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ff795c6
Fix label creation screen padding
irfano Sep 5, 2025
b29f723
Update package background in shipping label creation screen
irfano Sep 5, 2025
6b0dc18
Make entire custom package selection field clickable
irfano Sep 5, 2025
4a2473c
Update release notes for Shipping Labels
irfano Sep 5, 2025
e47d89c
Fix ripple effect issue on selected package card
irfano Sep 8, 2025
3ddd03f
Merge branch 'trunk' into issue/WOOMOB-12-enhance-selected-shipping-p…
irfano Sep 8, 2025
b6f796c
Merge branch 'trunk' into issue/WOOMOB-12-enhance-selected-shipping-p…
hichamboushaba Sep 11, 2025
03c95fd
Move release note to correct version
hichamboushaba Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions RELEASE-NOTES.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
- [*] Add more filter options to orders filters sales channel [https://github.com/woocommerce/woocommerce-android/pull/14546]
- [*] Automatically populate the weight field in the create shipment flow [https://github.com/woocommerce/woocommerce-android/pull/14525]
- [*] [Shipping Labels] Fixed displaying incorrect hazardous material option for purchased labels [https://github.com/woocommerce/woocommerce-android/pull/14571]
- [*] Shipping Labels: Enhance selected package UI in the create shipping label flow [https://github.com/woocommerce/woocommerce-android/pull/14579]

23.1
-----
Expand Down
8 changes: 4 additions & 4 deletions ...lin/com/woocommerce/android/ui/orders/wooshippinglabels/WooShippingLabelCreationScreen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -722,12 +722,12 @@ private fun PackageSelectionAvailableCard(
Column(
modifier = Modifier
.fillMaxWidth()
.border(
width = 1.dp,
color = colorResource(id = R.color.divider_color),
.clickable(onClick = onSelectPackageClick)
.background(
color = colorResource(R.color.light_colored_button_background),
shape = RoundedCornerShape(8.dp)
)
Copy link
Member

@hichamboushaba hichamboushaba Sep 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

np, same remark as this comment #14576 (comment)

Copy link
Contributor Author

@irfano irfano Sep 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 Fixed: e47d89c

.padding(dimensionResource(id = R.dimen.major_125)),
.padding(16.dp),
) {
Row(
verticalAlignment = Alignment.CenterVertically,
Expand Down