Skip to content

Conversation

@irfano
Copy link
Contributor

@irfano irfano commented Sep 5, 2025

Closes WOOMOB-12

Description

This PR enhances the package selection UI by:

  • Adding a gray background to the selected package box
  • Updating paddings
  • Making the box tappable

Steps to reproduce

  1. Go to Orders.
  2. Select an order that is eligible to create shipping labels.
  3. Tap "Create shipping label" button.
  4. Tap "Select a Package" button.
  5. Select a package.

The tests that have been performed

Screens below.

Images/gif

Before After
before after
before-dark after-dark
  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

The padding for the label creation screen has been updated from 20dp to 16dp.
The background of the package information section in the WooShipping label creation screen is updated.
The border is removed and replaced with a background color.
@irfano irfano added this to the 23.3 milestone Sep 5, 2025
@irfano irfano added feature: shipping labels Related to creating, ordering, or printing shipping labels. Enhancement labels Sep 5, 2025
The release notes are updated to reflect the enhancement of the selected package UI in the create shipping label flow.
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Sep 5, 2025

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit03c95fd
Direct Downloadwoocommerce-wear-prototype-build-pr14579-03c95fd.apk

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Sep 5, 2025

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit03c95fd
Direct Downloadwoocommerce-prototype-build-pr14579-03c95fd.apk

@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 38.34%. Comparing base (9504090) to head (03c95fd).
⚠️ Report is 9 commits behind head on trunk.

Additional details and impacted files
@@             Coverage Diff              @@
##              trunk   #14579      +/-   ##
============================================
- Coverage     38.34%   38.34%   -0.01%     
+ Complexity     9692     9691       -1     
============================================
  Files          2057     2057              
  Lines        115173   115173              
  Branches      15314    15314              
============================================
- Hits          44159    44158       -1     
  Misses        66940    66940              
- Partials       4074     4075       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@hichamboushaba hichamboushaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment on lines 725 to 729
.clickable(onClick = onSelectPackageClick)
.background(
color = colorResource(R.color.light_colored_button_background),
shape = RoundedCornerShape(8.dp)
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

np, same remark as this comment #14576 (comment)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 Fixed: e47d89c

@JorgeMucientes
Copy link
Contributor

I see this PR was reviewed and approved (and the np fixed). Do you think we can merge this @hichamboushaba ? Irfan is going to be AFK for a while.

@hichamboushaba
Copy link
Member

I see this PR was reviewed and approved (and the np fixed). Do you think we can merge this @hichamboushaba ? Irfan is going to be AFK for a while.

I'm not sure why it's not merged, Irfan enabled auto-merge and everything is green, Github didn't merge it yet, I'll merge it manually, I'll just move the release note to the correct version first.

@hichamboushaba hichamboushaba merged commit 8e63181 into trunk Sep 11, 2025
16 of 17 checks passed
@hichamboushaba hichamboushaba deleted the issue/WOOMOB-12-enhance-selected-shipping-package-ui branch September 11, 2025 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement feature: shipping labels Related to creating, ordering, or printing shipping labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants