-
Notifications
You must be signed in to change notification settings - Fork 136
[Shipping Labels] Enhance selected shipping package UI #14579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Shipping Labels] Enhance selected shipping package UI #14579
Conversation
The padding for the label creation screen has been updated from 20dp to 16dp.
The background of the package information section in the WooShipping label creation screen is updated. The border is removed and replaced with a background color.
The release notes are updated to reflect the enhancement of the selected package UI in the create shipping label flow.
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## trunk #14579 +/- ##
============================================
- Coverage 38.34% 38.34% -0.01%
+ Complexity 9692 9691 -1
============================================
Files 2057 2057
Lines 115173 115173
Branches 15314 15314
============================================
- Hits 44159 44158 -1
Misses 66940 66940
- Partials 4074 4075 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hichamboushaba
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
| .clickable(onClick = onSelectPackageClick) | ||
| .background( | ||
| color = colorResource(R.color.light_colored_button_background), | ||
| shape = RoundedCornerShape(8.dp) | ||
| ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
np, same remark as this comment #14576 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻 Fixed: e47d89c
|
I see this PR was reviewed and approved (and the np fixed). Do you think we can merge this @hichamboushaba ? Irfan is going to be AFK for a while. |
I'm not sure why it's not merged, Irfan enabled auto-merge and everything is green, Github didn't merge it yet, I'll merge it manually, I'll just move the release note to the correct version first. |
Closes WOOMOB-12
Description
This PR enhances the package selection UI by:
Steps to reproduce
The tests that have been performed
Screens below.
Images/gif
RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.