Skip to content

[Woo POS][Local Catalog][Beta 23.6] Do not show "Local Catalog syncing" state if local catalog is disabled #14907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 5, 2025
Merged

[Woo POS][Local Catalog][Beta 23.6] Do not show "Local Catalog syncing" state if local catalog is disabled #14907

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .../kotlin/com/woocommerce/android/ui/woopos/home/items/products/WooPosProductsDataSource.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,6 @@ class WooPosProductsDataSource @Inject constructor(
private var activeSource: WooPosProductsDataSourceInterface? = null

fun prepopulateCache(): Flow<WooPosPrepopulatingDataStatus> = flow {
emit(WooPosPrepopulatingDataStatus.Syncing)

val requirement = syncStatusChecker.checkSyncRequirement()
when (requirement) {
is WooPosFullSyncRequirement.LocalCatalogDisabled -> {
Expand All @@ -80,6 +78,7 @@ class WooPosProductsDataSource @Inject constructor(
}

is WooPosFullSyncRequirement.BlockingRequired -> {
emit(WooPosPrepopulatingDataStatus.Syncing)
activeSource = localDbDataSource
localDbDataSource.prepopulateCache().fold(
onSuccess = {
Expand Down