Skip to content

Conversation

@samiuelson
Copy link
Contributor

@samiuelson samiuelson commented Nov 5, 2025

WOOMOB-1638

Description

This PR fixes showing "Local Catalog syncing" state—previously it was shown in case local catalog was disabled and we were prepopulating in-memory cache in Splash screen.

Test Steps

  • With store not eligible for using Local Catalog, the Splash screen should show old progress bar during prepopulation of in-memory cache
  • With store eligible for using Local Catalog, the Splash screen should show "Local Catalog syncing" state only in case the blocking sync is needed.

Images/gif

  1. store eligible for using Local Catalog - full sync blocking required (e.g. sync never performed before):
Screen_recording_20251105_181314.mp4
  1. store not eligible for using Local Catalog:
Screen_recording_20251105_175943.mp4
  1. store eligible for using Local Catalog - full sync non-blocking required
Screen_recording_20251105_180008.mp4
  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

@samiuelson samiuelson added the Bug label Nov 5, 2025
@samiuelson samiuelson added this to the 23.6 ❄️ milestone Nov 5, 2025
@samiuelson samiuelson marked this pull request as ready for review November 5, 2025 17:32
@samiuelson samiuelson changed the title [Woo POS][Local Catalog]Do not show "Local Catalog syncing" state if local catalog is disabled [Woo POS][Local Catalog][Beta 23.6] Do not show "Local Catalog syncing" state if local catalog is disabled Nov 5, 2025
@dangermattic
Copy link
Collaborator

dangermattic commented Nov 5, 2025

1 Warning
⚠️ This PR is assigned to the milestone 23.6 ❄️. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@malinajirka malinajirka self-assigned this Nov 5, 2025
@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App NameWooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commitc1beca9
Direct Downloadwoocommerce-wear-prototype-build-pr14907-c1beca9.apk

Copy link
Contributor

@malinajirka malinajirka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected, thanks!

@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App NameWooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commitc1beca9
Direct Downloadwoocommerce-prototype-build-pr14907-c1beca9.apk

@samiuelson samiuelson merged commit 7b471e1 into release/23.6 Nov 5, 2025
25 checks passed
@samiuelson samiuelson deleted the woomob-1638-beta-236-local-catalog-splash-screen-shown-even-for-non branch November 5, 2025 19:48
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 38.26%. Comparing base (910c3d2) to head (c1beca9).
⚠️ Report is 9 commits behind head on release/23.6.

Files with missing lines Patch % Lines
...os/home/items/products/WooPosProductsDataSource.kt 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##             release/23.6   #14907      +/-   ##
==================================================
- Coverage           38.26%   38.26%   -0.01%     
+ Complexity          10091    10090       -1     
==================================================
  Files                2137     2137              
  Lines              120957   120957              
  Branches            16571    16571              
==================================================
- Hits                46281    46280       -1     
  Misses              69971    69971              
- Partials             4705     4706       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants