Skip to content

Conversation

@toupper
Copy link
Contributor

@toupper toupper commented Nov 11, 2025

Description

With this quick PR we fix a glitch happening when the product has a long title in POS Orders. With two lines, it overlaps the bottom text of quantity. We fix it by pinning the quantity text to the title, instead of to the image.

Test Steps

With a long product title and a POS Order containing that product:

  • Go to POS Orders
  • Check that the title doesn't overlap the quantity text

Images/gif

Before

Screenshot_20251111_162453_Woo (Dev)

After

Screenshot_20251111_162244_Woo (Dev)

  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

@toupper toupper added this to the 23.6 ❄️ milestone Nov 11, 2025
@toupper toupper requested a review from kidinov November 11, 2025 15:31
@toupper toupper added type: bug A confirmed bug. feature: POS labels Nov 11, 2025
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Nov 11, 2025

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App NameWooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit65318c0
Direct Downloadwoocommerce-wear-prototype-build-pr14935-65318c0.apk

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Nov 11, 2025

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App NameWooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit65318c0
Direct Downloadwoocommerce-prototype-build-pr14935-65318c0.apk

@kidinov kidinov self-assigned this Nov 12, 2025
Copy link
Contributor

@kidinov kidinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'd suggest to add one long name to WooPosOrderDetailsPreview so it's clear in the preview that this case is handled

@toupper
Copy link
Contributor Author

toupper commented Nov 12, 2025

LGTM! I'd suggest to add one long name to WooPosOrderDetailsPreview so it's clear in the preview that this case is handled

Sure! Done in 65318c0

@toupper toupper merged commit 4172843 into fix/pos-historical-orders-fixes-for-beta Nov 12, 2025
6 of 7 checks passed
@toupper toupper deleted the fix/pos-historical-orders-long-product-names branch November 12, 2025 10:22
@toupper toupper mentioned this pull request Nov 13, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants