Privacy Banner: handle Settings CTA #9107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
…s, mark privacy banner as seen
…rivacy Banner as seen
Collaborator
You can test the changes on this Pull Request by downloading an installable build, or scanning this QR code:
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## feature/new_privacy_screen #9107 +/- ##
================================================================
- Coverage 43.75% 43.71% -0.05%
Complexity 4136 4136
================================================================
Files 845 846 +1
Lines 44323 44369 +46
Branches 5820 5831 +11
================================================================
+ Hits 19394 19395 +1
- Misses 23225 23270 +45
Partials 1704 1704
☔ View full report in Codecov by Sentry. |
Generated by 🚫 dangerJS |
Comment on lines
+47
to
+74
| launch { | ||
| if (repository.isUserWPCOM()) { | ||
| _state.value = _state.value?.copy(loading = true) | ||
| val event = | ||
| repository.updateTracksSetting(_state.value?.analyticsSwitchEnabled ?: false) | ||
| _state.value = _state.value?.copy(loading = false) | ||
|
|
||
| event.fold( | ||
| onSuccess = { | ||
| appPrefsWrapper.savedPrivacyBannerSettings = true | ||
| analyticsTrackerWrapper.sendUsageStats = analyticsPreference | ||
| triggerEvent(ShowSettings) | ||
| }, | ||
| onFailure = { | ||
| triggerEvent( | ||
| ShowErrorOnSettings( | ||
| requestedAnalyticsValue = if (analyticsPreference) RequestedAnalyticsValue.ENABLED | ||
| else RequestedAnalyticsValue.DISABLE | ||
| ) | ||
| ) | ||
| } | ||
| ) | ||
| } else { | ||
| appPrefsWrapper.savedPrivacyBannerSettings = true | ||
| analyticsTrackerWrapper.sendUsageStats = analyticsPreference | ||
| triggerEvent(ShowSettings) | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
np: We might want to unit test this in the future
| } | ||
| } | ||
|
|
||
| @Suppress("MagicNumber") |
atorresveiga
approved these changes
May 25, 2023
Contributor
atorresveiga
left a comment
atorresveiga
left a comment
There was a problem hiding this comment.
Great work @wzieba. Everything worked as expected!
LGTM! 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #8949
Description
This PR adds behavior after pressing "Settings" button on the Privacy Banner. The behavior is described in #8949 and should match iOS described in woocommerce/woocommerce-ios#9802
It targets
feature/new_privacy_screenbecause I needed to provide changes in the Privacy Screen to make it possible to show an error message.Testing instructions
Every test case should start with opening the Privacy Banner: you should use VPN connection if needed to any European country. To show the banner at the next fresh app launch without reinstalling the app, please use option in Developer Settings.
WPCOM account
All tests in this section should be performed when logged in as WPCOM user
TC 1 Not updating settings
TC 2 Updating settings
TC 3 Not updating settings + error
TC 4 Updating settings + error
Non-WPCOM account
In the case of non-WPCOM account, it doesn't matter whether we change the initial setting or not, there's also no chance for the error.
TC1
Images/gif
RELEASE-NOTES.txtif necessary.