Skip to content

Conversation

@iamgabrielma
Copy link
Contributor

@iamgabrielma iamgabrielma commented Mar 24, 2025

Description

As part (1) of cleaning up and submitting this HACK week project, this PR adds a feature flag and renders the AI settings row under the app's Menu.

Testing information

  • Switch allowMerchantAIAPIKey to true
  • Navigate to Menu, observe there's an AI Settings row:
  • Tapping on it will render an empty view, and log the hub_menu_ai_settings_tapped event:
🔵 Tracked hub_menu_ai_settings_tapped, properties: [store_id: c5bd46cc-1804-4f7b-badb-bb98c449127f, was_ecommerce_trial: false, plan: , blog_id: -1, is_wpcom_store: false, site_url: https://indiemelon.mystagingwebsite.com]

Simulator Screenshot - iPad Air 11 - iOS 17 5 M2 (US site) - 2025-03-24 at 15 01 33


  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on all devices (phone/tablet) and no regressions are added.

@iamgabrielma iamgabrielma added this to the 22.1 milestone Mar 24, 2025
@iamgabrielma iamgabrielma added type: enhancement A request for an enhancement. feature: add/edit products Related to adding or editing products. labels Mar 24, 2025
@iamgabrielma iamgabrielma requested a review from jaclync March 24, 2025 08:15
@iamgabrielma iamgabrielma marked this pull request as ready for review March 24, 2025 08:15
@iamgabrielma iamgabrielma added the category: tracks Related to analytics, including Tracks Events. label Mar 24, 2025
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Mar 24, 2025

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr15404-6060f22
Version22.0
Bundle IDcom.automattic.alpha.woocommerce
Commit6060f22
App Center BuildWooCommerce - Prototype Builds #13410
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Copy link
Contributor

@jaclync jaclync left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 maybe the HACK Week p2 can be linked in the PR or the linked main GitHub issue?

Switch allowMerchantAIAPIKey to true

How about setting the feature flag to return buildConfig == .localDeveloper || buildConfig == .alpha for easier developement & PR testing?

Tapping on it will render an empty view, and log the hub_menu_ai_settings_tapped event

There's already an event hub_menu_option_tapped with option: ai property logged by default. WDYT about just using this event, with the option value maybe more specific like ai-settings?

@iamgabrielma
Copy link
Contributor Author

LGTM 🚀 maybe the HACK Week p2 can be linked in the PR or the linked main GitHub issue?

Done!

How about setting the feature flag to return buildConfig == .localDeveloper || buildConfig == .alpha for easier developement & PR testing?

Yeah, I was wary of this because is an empty view for now 😅 . Updated here: 780b945

There's already an event hub_menu_option_tapped with option: ai property logged by default. WDYT about just using this event, with the option value maybe more specific like ai-settings?

Oh, better! Updated: 89f9f4a

@iamgabrielma iamgabrielma enabled auto-merge March 25, 2025 13:44
@iamgabrielma iamgabrielma merged commit 0366ca7 into trunk Mar 26, 2025
13 checks passed
@iamgabrielma iamgabrielma deleted the hack/allowMerchantAIAPIKey-feature-flag branch March 26, 2025 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: tracks Related to analytics, including Tracks Events. feature: add/edit products Related to adding or editing products. type: enhancement A request for an enhancement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants