-
Notifications
You must be signed in to change notification settings - Fork 121
[Shipping Labels] Show options to move selected items #15418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
itsmeichigo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The layout looks good to me! I left some comments regarding the choice of structures, but please feel free to merge and I can handle the changes as part of handling the moving of items.
| Text(viewModel.itemsDetailLabel) | ||
| .foregroundStyle(Color(.textSubtle)) | ||
| } | ||
| ZStack(alignment: .bottom) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| let viewModel: MoveToShipmentNoticeViewModel | ||
|
|
||
| var body: some View { | ||
| HStack { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be an adaptive stack instead to ensure the contents are readable when the font size is really large on a narrow device.
|
Actually I'll merge the PR now to unblock the work for #15307. Thank you! |

Closes: #15306
Description
Add a notice to move items between shipments when items are selected. Moved the instructions notice into a subview to be able to show the notices in a VStack (one below another).
Changes
MoveToShipmentNoticeview with options to move to new shipment or existing shipments.Steps to reproduce
Testing information
Screenshots
Video recording
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-03-25.at.18.55.50.mp4
Screenshots
RELEASE-NOTES.txtif necessary.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: