[POS as a tab i1] Remove unused POS eligibility checker use case in Experimental Features

[jaclync]

Closes WOOMOB-587

Just one reviewer is required.

Description

This pull request removes the unused POSEligibilityChecker dependency in BetaFeaturesConfigurationViewModel as we might be making changes to it for the POS as a tab project. I'm separating the diffs from #15726 so that these changes are easier to review and test.

Code simplification and dependency removal:

• Removed the POSEligibilityCheckerProtocol dependency from BetaFeaturesConfigurationViewModel and its initializer. The logic for filtering availableFeatures no longer relies on POS eligibility checks, simplifying the class and reducing dependency coupling. (BetaFeaturesConfigurationViewModel.swift, WooCommerce/Classes/ViewRelated/Dashboard/Settings/Beta features/BetaFeaturesConfigurationViewModel.swiftL9-R25)
• Updated the availableFeatures filtering logic to directly check feature flags without involving the POSEligibilityChecker. (BetaFeaturesConfigurationViewModel.swift, WooCommerce/Classes/ViewRelated/Dashboard/Settings/Beta features/BetaFeaturesConfigurationViewModel.swiftL9-R25)

Unit test updates:

• Removed the MockPOSEligibilityChecker class and its usage in BetaFeaturesConfigurationViewModelTests. Updated the test cases to align with the changes in the BetaFeaturesConfigurationViewModel initializer and logic. (BetaFeaturesConfigurationViewModelTests.swift, WooCommerce/WooCommerceTests/Model/BetaFeaturesConfigurationViewModelTests.swiftL19-L37)

Steps to reproduce

• Go to Menu > Settings > Experimental Features --> there should be two features, add-ons and IAP (unrelated to this PR, we probably want to revisit these features to either fully launch or remove them)
• Try toggling the switch then re-enter this screen to make sure the switch state is persisted

Screenshots

---

• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

[dangermattic]

	1 Warning
⚠️	This PR is assigned to the milestone 22.6. This milestone is due in less than 2 days. Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

[wpmobilebot]

📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce iOS Prototype
	Build Number	30356
	Version	PR #15731
	Bundle ID	com.automattic.alpha.woocommerce
	Commit	f70f545
	Installation URL	5squceggi389o

Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

[iamgabrielma]

LGTM

unrelated to this PR, we probably want to revisit these features to either fully launch or remove them

Agree, this is logged as backlog on WOOMOB-56, we haven't needed the beta toggles for a while now.

[iamgabrielma]

Just an additional comment as I was checking related PRs, if we want to use a new POSEntryPointEligibilityCheckerProtocol moving forward, maybe we don't need the POSEligibilityCheckerProtocol itself from here on and can be removed as well.

[jaclync]

Just an additional comment as I was checking related PRs, if we want to use a new POSEntryPointEligibilityCheckerProtocol moving forward, maybe we don't need the POSEligibilityCheckerProtocol itself from here on and can be removed as well.

Thanks for checking, I think POSEligibilityCheckerProtocol will still be around for a bit for the Menu tab entry point until we remove the pointOfSaleAsATabi1 feature flag.