Skip to content

[POS as a tab i1] Remove unused POS eligibility checker use case in Experimental Features #15731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2025
Merged

[POS as a tab i1] Remove unused POS eligibility checker use case in Experimental Features #15731

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 9 additions & 29 deletions ...ses/ViewRelated/Dashboard/Settings/Beta features/BetaFeaturesConfigurationViewModel.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,42 +6,22 @@ final class BetaFeaturesConfigurationViewModel: ObservableObject {
@Published private(set) var availableFeatures: [BetaFeature] = []
private let appSettings: GeneralAppSettingsStorage
private let featureFlagService: FeatureFlagService
private let posEligibilityChecker: POSEligibilityCheckerProtocol

init(appSettings: GeneralAppSettingsStorage = ServiceLocator.generalAppSettings,
featureFlagService: FeatureFlagService = ServiceLocator.featureFlagService,
posEligibilityChecker: POSEligibilityCheckerProtocol = POSEligibilityChecker(
siteSettings: ServiceLocator.selectedSiteSettings,
currencySettings: ServiceLocator.currencySettings,
featureFlagService: ServiceLocator.featureFlagService
)) {
featureFlagService: FeatureFlagService = ServiceLocator.featureFlagService) {
self.appSettings = appSettings
self.featureFlagService = featureFlagService
self.posEligibilityChecker = posEligibilityChecker
observePOSEligibilityForAvailableFeatures()
availableFeatures = BetaFeature.allCases.filter { betaFeature in
switch betaFeature {
case .viewAddOns:
return true
case .inAppPurchases:
return featureFlagService.isFeatureFlagEnabled(.inAppPurchasesDebugMenu)
}
}
}

func isOn(feature: BetaFeature) -> Binding<Bool> {
appSettings.betaFeatureEnabledBinding(feature)
}
}

private extension BetaFeaturesConfigurationViewModel {
func observePOSEligibilityForAvailableFeatures() {
posEligibilityChecker.isEligible
.map { [weak self] isEligibleForPOS in
guard let self else {
return []
}
return BetaFeature.allCases.filter { betaFeature in
switch betaFeature {
case .viewAddOns:
return true
case .inAppPurchases:
return self.featureFlagService.isFeatureFlagEnabled(.inAppPurchasesDebugMenu)
}
}
}
.assign(to: &$availableFeatures)
}
}
15 changes: 1 addition & 14 deletions WooCommerce/WooCommerceTests/Model/BetaFeaturesConfigurationViewModelTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,22 +16,9 @@ final class BetaFeaturesConfigurationViewModelTests: XCTestCase {

func test_availableFeatures_include_viewAddOns() {
// Given
let viewModel = BetaFeaturesConfigurationViewModel(appSettings: appSettings,
posEligibilityChecker: MockPOSEligibilityChecker(isEligibleValue: true))
let viewModel = BetaFeaturesConfigurationViewModel(appSettings: appSettings)

// Then
XCTAssertTrue(viewModel.availableFeatures.contains(.viewAddOns))
}
}

private final class MockPOSEligibilityChecker: POSEligibilityCheckerProtocol {
@Published var isEligibleValue: Bool

init(isEligibleValue: Bool) {
self.isEligibleValue = isEligibleValue
}

var isEligible: AnyPublisher<Bool, Never> {
$isEligibleValue.eraseToAnyPublisher()
}
}