-
Notifications
You must be signed in to change notification settings - Fork 121
[POS as a tab i1] Analytics and enable local feature flag for public release #15766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Generated by 🚫 Danger |
|
|
staskus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well 👍
As you mentioned, pointOfSaleTabReselected doesn't get tracked, we could skip it entirely with the comment, saying that POS is presented on top of the context and cannot be reselected.
# Conflicts: # WooCommerce/Classes/ViewRelated/MainTabBarController.swift # WooCommerce/WooCommerceTests/ViewRelated/MainTabBarControllerTests.swift
…with `assertionFailure` in case it can be triggered.
Good point, skipped the reselected event in 844618b. I was still a bit afraid of UX edge cases to be able to trigger the reselection, so I put an |
|
The events aren't shown in Tracks directory yet, I will register them tomorrow or next Monday WOOMOB-624. |

Just one review is required.
Follow-up tasks:
Description
This pull request enables POS as a tab i1 feature (moving the POS entry point from the Menu tab to a POS tab for eligible stores with the same eligibility criteria) with analytics in WOOMOB-570. The updates include enabling the POS tab feature flag, adding new analytics events for POS interactions, updating the release notes, and introducing a test to ensure analytics tracking works correctly after eligibility checks.
Feature Flag Changes:
Modules/Sources/Experiments/DefaultFeatureFlagService.swift: Updated thepointOfSaleAsATabi1feature flag to always returntrue, enabling the POS tab for all builds.Analytics Enhancements:
WooCommerce/Classes/Analytics/WooAnalyticsStat.swift: Added new analytics events for POS tab interactions, including selection, reselection, and visibility checks.WooCommerce/Classes/ViewRelated/MainTabBarController.swift: Integrated analytics tracking for POS tab selection (pointOfSaleTabSelected), reselection (pointOfSaleTabReselected), and visibility checks (pointOfSaleTabVisibilityChecked). [1] [2] [3]Documentation Updates:
RELEASE-NOTES.txt: Added a note highlighting the new POS tab feature in the app for eligible stores.Testing:
WooCommerce/WooCommerceTests/ViewRelated/MainTabBarControllerTests.swift: Added a unit test to verify that thepointOfSaleTabVisibilityCheckedevent is tracked correctly after an eligibility check.Steps to reproduce
🗒️ I haven't been able to trigger the POS tab reselection event, probably because the tab cannot be selected (as a tab item selected state).
Prerequisite: a WPCOM account that has at least two connected stores, one eligible for POS and the other one not eligible.
🔵 Tracked pos_tab_visibility_checked, properties: [is_visible: true, ...]🔵 Tracked main_tab_pos_selected. All following events should havepos_prefix🔵 Tracked pos_tab_visibility_checked, properties: [is_visible: false, ...]RELEASE-NOTES.txtif necessary.