Shipping Labels: Add new Networking type for WooShipping shipments #15885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itsmeichigo
added
type: task
Collaborator
|
|
Contributor
Author
|
Converting the PR back to draft for a better solution. |
itsmeichigo
changed the title
RafaelKayumov
approved these changes
Jul 10, 2025
Contributor
RafaelKayumov
left a comment
RafaelKayumov
left a comment
There was a problem hiding this comment.
LGTM. Works as described. Left couple questions.
| currency: currency) | ||
| shipmentContents.append(content) | ||
| let purchasedLabel: ShippingLabel? = { | ||
| guard let label = shipment.shippingLabel, label.refund == nil else { |
Contributor
There was a problem hiding this comment.
Should we also check for status here?
Contributor
Author
There was a problem hiding this comment.
@RafaelKayumov - status is already checked when populating labels in the shipments when decoding the config response. Could you share why it's necessary here?
| public let orderID: Int64 | ||
|
|
||
| /// Index of the shipment | ||
| public let index: String |
Contributor
There was a problem hiding this comment.
Could you please add a comment clarifying the index format?
1 task
RafaelKayumov
approved these changes
Jul 11, 2025
Contributor
RafaelKayumov
left a comment
RafaelKayumov
left a comment
There was a problem hiding this comment.
Thx for the updates 
itsmeichigo
deleted the
woomob-754-shipping-labels-update-shipping-label-section-in-order
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of WOOMOB-754
Description
To prepare for the update of the order details screen to show shipments, this PR adds a new type for WooShipping shipments and change the type of
shipmentsin the config fetched from the remote.The reasoning behind this change is that the shipments need to be saved to the local storage with a site ID and order ID for a better UX on the order details screen. The current dictionary cannot be persisted the same way.
The new
WooShippingShipmenttype also comes with an optionalshippingLabelproperty mapped from the data in the config response. The logic for managing shipping labels in the purchase flow has been simplified accordingly.In subsequent PRs, I'll add a new Core Data entity for the shipments and support syncing shipments from the order details form.
Testing steps
Testing information
Screenshots
No UI changes.
RELEASE-NOTES.txtif necessary.