Skip to content

Conversation

@iamgabrielma
Copy link
Contributor

@iamgabrielma iamgabrielma commented Aug 6, 2025

Closes WOOMOB-1004

Description

This PR addresses ~20 of the non-behavioral compiler warnings as part of pre-work for the the app's iOS17 bump:

  1. 'public' modifier is redundant for enum declared in a public extension

Removed public access control for an already public extension: 45fea39

  1. '@Namespace' used inline will not work unless tagged with '@Previewable' (from macro 'Preview')

Marked previews that use the Namespace tag as @previewable: a3d1440 . This adds an additional iOS17 check for each preview, but all of them will be removed in one go as soon as we bump the minimum target on a separate issue.

Testing information

  • App should compile normally
  • Run the app in a simulator and physical device, should init normally. Free free to navigate around, but nothing should have changed behavior-wise.
  • CI should pass

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@dangermattic
Copy link
Collaborator

dangermattic commented Aug 6, 2025

1 Warning
⚠️ View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.

Generated by 🚫 Danger

@iamgabrielma iamgabrielma added type: task An internally driven task. type: technical debt Represents or solves tech debt of the project. labels Aug 6, 2025
@iamgabrielma iamgabrielma added this to the 23.0 milestone Aug 6, 2025
@iamgabrielma iamgabrielma marked this pull request as ready for review August 6, 2025 05:34
@wpmobilebot
Copy link
Collaborator

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Numberpr15981-a3d1440
Version22.9
Bundle IDcom.automattic.alpha.woocommerce
Commita3d1440
Installation URL0929s4qok7o4g
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@iamgabrielma
Copy link
Contributor Author

Only one review is needed!

@itsmeichigo itsmeichigo self-assigned this Aug 6, 2025
@iamgabrielma iamgabrielma merged commit dc42a78 into trunk Aug 6, 2025
26 checks passed
@iamgabrielma iamgabrielma deleted the task/wcios17-warnings-previewable-macro branch August 6, 2025 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: task An internally driven task. type: technical debt Represents or solves tech debt of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants