Skip to content

[WCiOS17] Address non-behavioral compiler warnings #15981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 6, 2025
Merged

[WCiOS17] Address non-behavioral compiler warnings #15981

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
45fea39
remove warning for redundant access control public extension
iamgabrielma Aug 6, 2025
a3d1440
Add previewable tag requirement to previews using namespace
iamgabrielma Aug 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Modules/Sources/NetworkingCore/Remote/Remote.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,7 +370,7 @@ public extension Remote {
public static let firstPageNumber: Int = 1
}

public enum PaginationHeaderKey {
enum PaginationHeaderKey {
public static let totalPagesCount = "x-wp-totalpages"
public static let totalCount = "x-wp-total"
}
Expand Down
3 changes: 2 additions & 1 deletion ...UI States/Connection Alerts/PointOfSaleCardPresentPaymentBluetoothRequiredAlertView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,9 @@ struct PointOfSaleCardPresentPaymentBluetoothRequiredAlertView: View {
}
}

@available(iOS 17.0, *)
#Preview {
@Namespace var namespace
@Previewable @Namespace var namespace
return PointOfSaleCardPresentPaymentBluetoothRequiredAlertView(
viewModel: .init(error: NSError(domain: "", code: 1),
endSearch: {}),
Expand Down
3 changes: 2 additions & 1 deletion ...tes/Connection Alerts/PointOfSaleCardPresentPaymentConnectingFailedChargeReaderView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,9 @@ struct PointOfSaleCardPresentPaymentConnectingFailedChargeReaderView: View {
}
}

@available(iOS 17.0, *)
#Preview {
@Namespace var namespace
@Previewable @Namespace var namespace
return PointOfSaleCardPresentPaymentConnectingFailedChargeReaderView(
viewModel: PointOfSaleCardPresentPaymentConnectingFailedChargeReaderAlertViewModel(
retryButtonAction: {},
Expand Down
3 changes: 2 additions & 1 deletion ...ction Alerts/PointOfSaleCardPresentPaymentConnectingFailedLocationRequiredAlertView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,9 @@ struct PointOfSaleCardPresentPaymentConnectingFailedLocationRequiredAlertView: V
}
}

@available(iOS 17.0, *)
#Preview {
@Namespace var namespace
@Previewable @Namespace var namespace
PointOfSaleCardPresentPaymentConnectingFailedLocationRequiredAlertView(
viewModel: PointOfSaleCardPresentPaymentConnectingFailedLocationRequiredAlertViewModel(cancelSearchAction: {}),
animation: .init(namespace: namespace)
Expand Down
3 changes: 2 additions & 1 deletion ...tes/Connection Alerts/PointOfSaleCardPresentPaymentConnectingFailedNonRetryableView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,9 @@ struct PointOfSaleCardPresentPaymentConnectingFailedNonRetryableView: View {
}
}

@available(iOS 17.0, *)
#Preview {
@Namespace var namespace
@Previewable @Namespace var namespace
return PointOfSaleCardPresentPaymentConnectingFailedNonRetryableView(
viewModel: PointOfSaleCardPresentPaymentConnectingFailedNonRetryableAlertViewModel(
error: NSError(domain: "payments error", code: 1),
Expand Down
3 changes: 2 additions & 1 deletion ...es/Connection Alerts/PointOfSaleCardPresentPaymentConnectingFailedUpdateAddressView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,9 @@ struct PointOfSaleCardPresentPaymentConnectingFailedUpdateAddressView: View {
}
}

@available(iOS 17.0, *)
#Preview {
@Namespace var namespace
@Previewable @Namespace var namespace
return PointOfSaleCardPresentPaymentConnectingFailedUpdateAddressView(
viewModel: PointOfSaleCardPresentPaymentConnectingFailedUpdateAddressAlertViewModel(
settingsAdminUrl: URL(string: "http://example.com")!,
Expand Down
3 changes: 2 additions & 1 deletion ...Connection Alerts/PointOfSaleCardPresentPaymentConnectingFailedUpdatePostalCodeView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,9 @@ struct PointOfSaleCardPresentPaymentConnectingFailedUpdatePostalCodeView: View {
}
}

@available(iOS 17.0, *)
#Preview {
@Namespace var namespace
@Previewable @Namespace var namespace
return PointOfSaleCardPresentPaymentConnectingFailedUpdatePostalCodeView(
viewModel: PointOfSaleCardPresentPaymentConnectingFailedUpdatePostalCodeAlertViewModel(
retryButtonAction: { },
Expand Down
3 changes: 2 additions & 1 deletion ...ction/UI States/Connection Alerts/PointOfSaleCardPresentPaymentConnectingFailedView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,9 @@ struct PointOfSaleCardPresentPaymentConnectingFailedView: View {
}
}

@available(iOS 17.0, *)
#Preview {
@Namespace var namespace
@Previewable @Namespace var namespace
return PointOfSaleCardPresentPaymentConnectingFailedView(
viewModel: PointOfSaleCardPresentPaymentConnectingFailedAlertViewModel(
error: NSError(domain: "preview.error", code: 1),
Expand Down
3 changes: 2 additions & 1 deletion ...tates/Connection Alerts/PointOfSaleCardPresentPaymentConnectingLocationPreAlertView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,9 @@ struct PointOfSaleCardPresentPaymentConnectingLocationPreAlertView: View {
}
}

@available(iOS 17.0, *)
#Preview {
@Namespace var namespace
@Previewable @Namespace var namespace
PointOfSaleCardPresentPaymentConnectingLocationPreAlertView(
viewModel: PointOfSaleCardPresentPaymentConnectingLocationPreAlertViewModel(requestPermissionAction: {}),
animation: .init(namespace: namespace)
Expand Down
3 changes: 2 additions & 1 deletion ...ion/UI States/Connection Alerts/PointOfSaleCardPresentPaymentConnectingToReaderView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,9 @@ struct PointOfSaleCardPresentPaymentConnectingToReaderView: View {
}
}

@available(iOS 17.0, *)
#Preview {
@Namespace var namespace
@Previewable @Namespace var namespace
return PointOfSaleCardPresentPaymentConnectingToReaderView(
viewModel: PointOfSaleCardPresentPaymentConnectingToReaderAlertViewModel(),
animation: .init(namespace: namespace)
Expand Down
3 changes: 2 additions & 1 deletion ...UI States/Connection Alerts/PointOfSaleCardPresentPaymentConnectionSuccessAlertView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,9 @@ struct PointOfSaleCardPresentPaymentConnectionSuccessAlertView: View {
}
}

@available(iOS 17.0, *)
#Preview {
@Namespace var namespace
@Previewable @Namespace var namespace
return PointOfSaleCardPresentPaymentConnectionSuccessAlertView(
viewModel: PointOfSaleCardPresentPaymentConnectionSuccessAlertViewModel(doneAction: {}),
animation: .init(namespace: namespace)
Expand Down
3 changes: 2 additions & 1 deletion ...Connection/UI States/Connection Alerts/PointOfSaleCardPresentPaymentFoundReaderView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,9 @@ struct PointOfSaleCardPresentPaymentFoundReaderView: View {
}
}

@available(iOS 17.0, *)
#Preview {
@Namespace var namespace
@Previewable @Namespace var namespace
return PointOfSaleCardPresentPaymentFoundReaderView(
viewModel: PointOfSaleCardPresentPaymentFoundReaderAlertViewModel(
readerName: "READER NAME",
Expand Down
3 changes: 2 additions & 1 deletion ...tes/Connection Alerts/PointOfSaleCardPresentPaymentReaderUpdateFailedLowBatteryView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,9 @@ struct PointOfSaleCardPresentPaymentReaderUpdateFailedLowBatteryView: View {
}
}

@available(iOS 17.0, *)
#Preview {
@Namespace var namespace
@Previewable @Namespace var namespace
return PointOfSaleCardPresentPaymentReaderUpdateFailedLowBatteryView(
viewModel: .init(batteryLevel: nil, retrySearchAction: {}, cancelUpdateAction: {}),
animation: .init(namespace: namespace)
Expand Down
3 changes: 2 additions & 1 deletion ...s/Connection Alerts/PointOfSaleCardPresentPaymentReaderUpdateFailedNonRetryableView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,9 @@ struct PointOfSaleCardPresentPaymentReaderUpdateFailedNonRetryableView: View {
}
}

@available(iOS 17.0, *)
#Preview {
@Namespace var namespace
@Previewable @Namespace var namespace
return PointOfSaleCardPresentPaymentReaderUpdateFailedNonRetryableView(
viewModel: .init(cancelUpdateAction: {}),
animation: .init(namespace: namespace)
Expand Down
3 changes: 2 additions & 1 deletion ...ion/UI States/Connection Alerts/PointOfSaleCardPresentPaymentReaderUpdateFailedView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,9 @@ struct PointOfSaleCardPresentPaymentReaderUpdateFailedView: View {
}
}

@available(iOS 17.0, *)
#Preview {
@Namespace var namespace
@Previewable @Namespace var namespace
return PointOfSaleCardPresentPaymentReaderUpdateFailedView(
viewModel: .init(retryAction: {}, cancelUpdateAction: {}),
animation: .init(namespace: namespace)
Expand Down
3 changes: 2 additions & 1 deletion ... States/Connection Alerts/PointOfSaleCardPresentPaymentScanningForReadersFailedView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,9 @@ struct PointOfSaleCardPresentPaymentScanningForReadersFailedView: View {
}
}

@available(iOS 17.0, *)
#Preview {
@Namespace var namespace
@Previewable @Namespace var namespace
return PointOfSaleCardPresentPaymentScanningForReadersFailedView(
viewModel: PointOfSaleCardPresentPaymentScanningFailedAlertViewModel(
error: NSError(domain: "", code: 1, userInfo: nil),
Expand Down
3 changes: 2 additions & 1 deletion ...ion/UI States/Connection Alerts/PointOfSaleCardPresentPaymentScanningForReadersView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,9 @@ struct PointOfSaleCardPresentPaymentScanningForReadersView: View {
}
}

@available(iOS 17.0, *)
#Preview {
@Namespace var namespace
@Previewable @Namespace var namespace
return PointOfSaleCardPresentPaymentScanningForReadersView(
viewModel: PointOfSaleCardPresentPaymentScanningForReadersAlertViewModel(
endSearchAction: {}),
Expand Down
3 changes: 2 additions & 1 deletion ...I States/Reader Messages/PointOfSaleCardPresentPaymentActivityIndicatingMessageView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,9 @@ private extension PointOfSaleCardPresentPaymentActivityIndicatingMessageView {
}
}

@available(iOS 17.0, *)
#Preview {
@Namespace var namespace
@Previewable @Namespace var namespace
return PointOfSaleCardPresentPaymentActivityIndicatingMessageView(
title: "Checking order",
message: "Getting ready",
Expand Down
3 changes: 2 additions & 1 deletion ...UI States/Reader Messages/PointOfSaleCardPresentPaymentCancelledOnReaderMessageView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,9 @@ struct PointOfSaleCardPresentPaymentCancelledOnReaderMessageView: View {
}
}

@available(iOS 17.0, *)
#Preview {
@Namespace var namespace
@Previewable @Namespace var namespace
return PointOfSaleCardPresentPaymentCancelledOnReaderMessageView(
viewModel: PointOfSaleCardPresentPaymentCancelledOnReaderMessageViewModel(tryPaymentAgainButtonAction: {}),
animation: .init(namespace: namespace)
Expand Down
3 changes: 2 additions & 1 deletion ...tion/UI States/Reader Messages/PointOfSaleCardPresentPaymentCaptureErrorMessageView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,9 @@ struct PointOfSaleCardPresentPaymentCaptureErrorMessageView: View {
}
}

@available(iOS 17.0, *)
#Preview {
@Namespace var namespace
@Previewable @Namespace var namespace
return PointOfSaleCardPresentPaymentCaptureErrorMessageView(
viewModel: PointOfSaleCardPresentPaymentCaptureErrorMessageViewModel(
tryAgainButtonAction: {},
Expand Down
6 changes: 4 additions & 2 deletions ...rConnection/UI States/Reader Messages/PointOfSaleCardPresentPaymentErrorMessageView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,9 @@ struct PointOfSaleCardPresentPaymentErrorMessageView: View {
}
}

@available(iOS 17.0, *)
#Preview("Generic retry") {
@Namespace var namespace
@Previewable @Namespace var namespace

return PointOfSaleCardPresentPaymentErrorMessageView(
viewModel: PointOfSaleCardPresentPaymentErrorMessageViewModel(
Expand All @@ -69,8 +70,9 @@ struct PointOfSaleCardPresentPaymentErrorMessageView: View {
)
}

@available(iOS 17.0, *)
#Preview("Retry with another payment method") {
@Namespace var namespace
@Previewable @Namespace var namespace

return PointOfSaleCardPresentPaymentErrorMessageView(
viewModel: PointOfSaleCardPresentPaymentErrorMessageViewModel(
Expand Down
3 changes: 2 additions & 1 deletion ... States/Reader Messages/PointOfSaleCardPresentPaymentIntentCreationErrorMessageView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,9 @@ struct PointOfSaleCardPresentPaymentIntentCreationErrorMessageView: View {
}
}

@available(iOS 17.0, *)
#Preview {
@Namespace var namespace
@Previewable @Namespace var namespace

return PointOfSaleCardPresentPaymentIntentCreationErrorMessageView(
viewModel: PointOfSaleCardPresentPaymentIntentCreationErrorMessageViewModel(
Expand Down
3 changes: 2 additions & 1 deletion ...UI States/Reader Messages/PointOfSaleCardPresentPaymentNonRetryableErrorMessageView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,9 @@ struct PointOfSaleCardPresentPaymentNonRetryableErrorMessageView: View {
}
}

@available(iOS 17.0, *)
#Preview {
@Namespace var namespace
@Previewable @Namespace var namespace
return PointOfSaleCardPresentPaymentNonRetryableErrorMessageView(
viewModel: PointOfSaleCardPresentPaymentNonRetryableErrorMessageViewModel(
error: CardReaderServiceError.paymentCapture(
Expand Down
3 changes: 2 additions & 1 deletion ...States/Reader Messages/PointOfSaleCardPresentPaymentValidatingOrderErrorMessageView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,9 @@ struct PointOfSaleCardPresentPaymentValidatingOrderErrorMessageView: View {
}
}

@available(iOS 17.0, *)
#Preview {
@Namespace var namespace
@Previewable @Namespace var namespace
return PointOfSaleCardPresentPaymentValidatingOrderErrorMessageView(
viewModel: PointOfSaleCardPresentPaymentValidatingOrderErrorMessageViewModel(
error: CardReaderServiceError.paymentCapture(
Expand Down